swdev
swdev

Reputation: 5157

How to properly convert managed bitmap into unmanaged bitmap?

I am trying to create a textured Cube using OpenGL in Visual C++.NET 2008. After some googgling, using GLU, I found that I must use gluBuild2DMipmaps.

The problem Is, I read the bitmap using System::Drawing::Bitmap.FromFile()

Now, How do I pass this managed Bitmap object to gluBuild2DMipmaps, which accept const void * parameter???

I already try the LockBits using these code:

BYTE * data;
/*ambil raw data*/
System::Drawing::Rectangle rect =  System::Drawing::Rectangle(0,0,b->Width,b->Height);
System::Drawing::Imaging::BitmapData ^  bitmapData;
    b->LockBits(
        rect,
        System::Drawing::Imaging::ImageLockMode::ReadWrite, 
        b->PixelFormat ,bitmapData);

    ::memcpy(data,bitmapData->Scan0.ToPointer(),b->Width * b->Height);
gluBuild2DMipmaps(GL_TEXTURE_2D, 3, width, height,
                   GL_RGB, GL_UNSIGNED_BYTE, data);

Using a 24bpp BMP file, it stuck on the line lockbit with message System.ArgumentException : Additional information: Parameter is not valid.

What did I do wrong????


I just found the correct solution. It's because a couple of problem:

  1. I use the wrong overloaded function. See the different in how I call lockBits
  2. I am not initializing the pointer dataBitmap.
  3. And also, as GLuint * texture; is a managed pointer, I must convert it into unmanaged pointer using pin_pointer.

Thanks, and this is the correct method :

void CBox::LoadTextureRaw(String ^ filename, int wrap)
{
    //GLuint texture;

    System::Drawing::Bitmap ^ bitmap = gcnew Bitmap(filename);  
    int h = bitmap->Height;
    int w = bitmap->Width;
    int s = w * h;
    dataTexture = new BYTE[s * 3];

    System::Drawing::Rectangle rect =  System::Drawing::Rectangle(0,0,bitmap->Width,bitmap->Height);
    System::Drawing::Imaging::BitmapData ^  bitmapData = 
        bitmap->LockBits(rect,System::Drawing::Imaging::ImageLockMode::ReadWrite , System::Drawing::Imaging::PixelFormat::Format24bppRgb);

    ::memcpy(dataTexture,bitmapData->Scan0.ToPointer(),s);


    bitmap->UnlockBits(bitmapData); 
    pin_ptr<GLuint*> pt = &texture;//pin managed pointer, to be unmanaged... asyeeeem
    **pt = gluBuild2DMipmaps(GL_TEXTURE_2D, 3, w, h,GL_RGB, GL_UNSIGNED_BYTE, dataTexture);     
}

Upvotes: 0

Views: 3335

Answers (1)

Luca
Luca

Reputation: 11991

I use the following code to copy Bitmap data:

Image image = null;
Bitmap iBitmap = new Bitmap(fs);
BitmapData iBitmapData;
GCHandle hImageData;

if ((iBitmap.Flags & (int)ImageFlags.ColorSpaceRgb) != 0) {
    switch (iBitmap.PixelFormat) {
        case PixelFormat.Format1bppIndexed:
        case PixelFormat.Format4bppIndexed:
        case PixelFormat.Format8bppIndexed:
            // Allocate image raster
            image = new RasterImage<ColorBGR8>(iBitmap.Width, iBitmap.Height);
            break;
        case PixelFormat.Format16bppRgb565:
            // Allocate image raster
            image = new RasterImage<ColorBGR16>(iBitmap.Width, iBitmap.Height);
            break;
        case PixelFormat.Format24bppRgb:
            // Allocate image raster
            image = new RasterImage<ColorBGR24>(iBitmap.Width, iBitmap.Height);
            break;
        case PixelFormat.Format32bppRgb:
            // Allocate image raster
            image = new RasterImage<ColorBGR32>(iBitmap.Width, iBitmap.Height);
            break;
        case PixelFormat.Format32bppArgb:
            // Allocate image raster
            image = new RasterImage<ColorABGR32>(iBitmap.Width, iBitmap.Height);
            break;
        default:
            throw new Exception("Image RGB pixel format not supported");
    }
} else if ((iBitmap.Flags & (int)ImageFlags.ColorSpaceGray) != 0) {
    switch (iBitmap.PixelFormat) {
        case PixelFormat.Format1bppIndexed:
        case PixelFormat.Format4bppIndexed:
        case PixelFormat.Format8bppIndexed:
            // Allocate image raster
            image = new RasterImage<ColorY8>(iBitmap.Width, iBitmap.Height);
            break;
        default:
            throw new Exception("Image GRAY pixel format not supported");
    }

    if (RenderContext.Caps.TextureSwizzle == false) {
        throw new Exception("unable to load GRAY pixel format image (ARB_texture_swizzle extension not supported)");
    }
} else if ((iBitmap.Flags & (int)ImageFlags.ColorSpaceYcbcr) != 0) {
    throw new Exception("Image YCbCr pixel format not supported");
} else if ((iBitmap.Flags & (int)ImageFlags.ColorSpaceYcck) != 0) {
    throw new Exception("Image YCCK pixel format not supported");
} else if ((iBitmap.Flags & (int)ImageFlags.ColorSpaceCmyk) != 0) {
    throw new Exception("Image CMYK pixel format not supported");
} else
    throw new Exception("Image pixel format not supported");

// Obtain source and destination data pointers
iBitmapData = iBitmap.LockBits(new Rectangle(0, 0, iBitmap.Width, iBitmap.Height), ImageLockMode.ReadOnly, iBitmap.PixelFormat);
hImageData = GCHandle.Alloc(image.GetPixelData(), GCHandleType.Pinned);

    // Alternative without using custom Image class:
    //T[,] buffer = new ColorRGB24[iBitmap.Width, iBitmap.Height];
    //hImageData = GCHandle.Alloc(buffer, GCHandleType.Pinned);

// Copy Bitmap data to Image
memcpy(hImageData.AddrOfPinnedObject(), iBitmapData.Scan0, iBitmapData.Stride*iBitmapData.Height);

hImageData.Free();
iBitmap.UnlockBits(iBitmapData);

return (image);

You can note I had to P/Invoke memcpy routine to copy locked memory.

The Image class is a class defined in my project, which defines the method GetPixelData() as a simple routine returning a T[,], where T is a structure like the following

[StructLayout(LayoutKind.Sequential, Pack = 1)]
public struct ColorRGB24 : IColorRGB<byte>
{
    public byte r;
    public byte g;
    public byte b;
}

Read the following quote:

Using System.Drawing.Imaging.PixelFormat values, such as Indexed and Gdi, will throw an System.ArgumentException

So, make sure to do not have the Indexed or Gdi pixel format values.

Upvotes: 1

Related Questions