Reputation: 363
I'm trying to convert this AsyncTask:
private static class UpdateFeedTask extends AsyncTask<Void, Void, Void> {
private WeakReference<FeedFragment> weakFeedFragment;
private UpdateFeedTask(FeedFragment feedFragment) {
this.weakFeedFragment = new WeakReference<>(feedFragment);
}
@Override
protected void onPreExecute() {
if (!weakFeedFragment.get().swipeRefreshLayout.isRefreshing()) {
weakFeedFragment.get().feedProgressBar.setVisibility(View.VISIBLE);
}
}
@Override
protected final Void doInBackground(Void... voids) {
weakFeedFragment.get().submissionList = weakFeedFragment.get().paginator.next();
return null;
}
@Override
protected void onPostExecute(Void value) {
weakFeedFragment.get().feedProgressBar.setVisibility(View.INVISIBLE);
weakFeedFragment.get().swipeRefreshLayout.setRefreshing(false);
weakFeedFragment.get().isLoadingNextSubmissions = false;
FeedAdapter feedAdapter = (FeedAdapter) weakFeedFragment.get().recyclerView.getAdapter();
feedAdapter.updateItems(weakFeedFragment.get().submissionList);
}
}
into a Single Observable, but when I call it, it does not initiate at all:
private void UpdateFeed() {
if (swipeRefreshLayout.isRefreshing()) {
feedProgressBar.setVisibility(View.VISIBLE);
}
updateFeedObservable()
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.subscribeWith(new SingleObserver<Listing<Submission>>() {
@Override public void onSubscribe(Disposable d) {
d.dispose();
}
@Override public void onSuccess(Listing<Submission> submissions) {
Log.d(TAG, "onSuccess: WORKS"); //Nope
feedProgressBar.setVisibility(View.INVISIBLE);
swipeRefreshLayout.setRefreshing(false);
isLoadingNextSubmissions = false;
FeedAdapter feedAdapter = (FeedAdapter) recyclerView.getAdapter();
feedAdapter.updateItems(submissions);
}
@Override public void onError(Throwable e) {
Log.e(TAG, e.getMessage());
}
});
}
public Single<Listing<Submission>> updateFeedObservable() {
return Single.defer(() -> Single.fromCallable(() -> {
Log.d(TAG, "updateFeedObservable: WORKS"); //Nope
return paginator.next();
}));
}
I tried changing the Scheduler but as far as I know, anything IO related needs to use Schedulers.io I'm not sure where exactly the problem is, any help would be appreciated
Upvotes: 0
Views: 130
Reputation: 9929
in new SingleObserver<Listing<Submission>>()::onSubscribe()
you immediately call d.dispose()
so you will never get the onSuccess()
call because when you subscribe you dispose of the SingleObserver
.
Remove : d.dispose()
Also this :
return Single.defer(() -> Single.fromCallable(() -> {
Log.d(TAG, "updateFeedObservable: WORKS"); // Nope
return paginator.next();
}));
Can be simplified to :
return Single.fromCallable(Paginator::next); // method reference
Upvotes: 3