CODEWITHSUNDEEP
c#linqgrouping
Ahmad Alfawwaz Timehin
Ahmad Alfawwaz Timehin

Reputation: 303

Efficient way of grouping characters in string c#

I want an efficient way of grouping strings whilst keeping duplicates and order. Something like this

1100110002200   -> 101020

I tried this previously

_case.GroupBy(c => c).Select(g => g.Key)

but I got 102

But this gives me what I want, I just want to optimize it, so I wouldn't have to scour the entire list each time

static List<char> group(string _case)
{
    var groups = new List<char>();
    for (int i = 0; i < _case.Length; i++)
    {
        if (groups.LastOrDefault() != _case[i])
            groups.Add(_case[i]);
    }
    return groups;
}

Upvotes: 0

Views: 1618

Answers (2)

Anton&#237;n Lejsek
Anton&#237;n Lejsek

Reputation: 6103

While I like the elegant solution of rshepp, it turns out that the very basic code can run even 5 times faster than that.

public static string Simplify2(string str)
{
    if (string.IsNullOrEmpty(str)) { return str; }

    StringBuilder sb = new StringBuilder();
    char last = str[0];
    sb.Append(last);

    foreach (char c in str)
    {
        if (last != c)
        {
            sb.Append(c);
            last = c;
        }
    }

    return sb.ToString();
}

Upvotes: 4

user6572277
user6572277

Reputation:

You could create a method that loops each character and checks the previous character for equality. If they aren't the same, append/yield return the character. This is pretty easy to do with Linq.

public static string Simplify(string str)
{
    return string.Concat(str.Where((c, i) => i == 0 || c != str[i - 1]));
}

Usage:

string simplified = Simplify("1100110002200");
// 101020

In my testing, my method and yours are roughly equal in speed, mine being insignificantly slower after 10 million executions (4260ms vs 4241ms).

However, my method returns the result as a string whereas yours doesn't. If you need to convert your result back to a string (which is likely) then my method is indeed much faster/more efficient (4260ms vs 6569ms).

Upvotes: 4

Related Questions