CODEWITHSUNDEEP
pythonflask
JohnWick
JohnWick

Reputation: 5149

Python + Flask Working outside of request context

I've got this python code, I am trying to redirect a user trying to access my websites homepage (ex: http://example.com/) to their profile page if they are logged in, but I receive this exception on line 13.

RuntimeError: Working outside of request context.

If I remove line 13, I receive a different exception.

KeyError: 'user_id'

from cs50 import SQL
from flask import Flask, flash, redirect, render_template, request, session
from flask_session import Session
from tempfile import mkdtemp
from werkzeug.exceptions import default_exceptions
from werkzeug.security import check_password_hash, generate_password_hash

app = Flask(__name__)
app.secret_key = "super secret key"
app.config["SESSION_TYPE"] = "filesystem"
db = SQL("sqlite:///data.db")
Session(app)
session['user_id'] = 0

@app.route("/")
def index():
    if session['user_id'] != 0:
        return redirect("profile/" + session['username'])
    return render_template("index.html")


@app.route("/login", methods=["GET", "POST"])
def login():
    """Log user in"""

    # Forget any user_id
    session.clear()
    session['user_id'] = 0
    # User reached route via POST (as by submitting a form via POST)
    if request.method == "POST":

        # Ensure username was submitted
        if not request.form.get("username"):
            return apology("must provide username", 403)

        # Ensure password was submitted
        elif not request.form.get("password"):
            return apology("must provide password", 403)

        # Query database for username
        rows = db.execute("SELECT * FROM users WHERE username = :username",
                          username=request.form.get("username"))

        # Ensure username exists and password is correct
        if len(rows) != 1 or not check_password_hash(rows[0]["passwordHash"], request.form.get("password")):
            return apology("invalid username and/or password", 403)

        # Remember which user has logged in
        session["user_id"] = rows[0]["id"]
        session["username"] = rows[0]["username"]

        return redirect("/")

Upvotes: 1

Views: 5445

Answers (1)

OneCricketeer
OneCricketeer

Reputation: 191963

session['user_id'] = 0 is outside of a request context body.

You should replace if session['user_id'] != 0: with if session.get('user_id',0) != 0: in order to get a default value for the session. Therefore fixing the KeyError

Then, you don't need to initialize any session keys

Upvotes: 3

Related Questions