CODEWITHSUNDEEP
jqueryhtmlcheckboxonchange
isxaker
isxaker

Reputation: 9506

Html checkBox onchange not working

<input class="jProblemClass" id="Checkbox{%= ID %}" type="checkbox" onchange="problemPicker.onChangeProblemCheckBox('{%=ID %}');"/>

After first check or uncheck nothing happens. Afetr second click, call my function problemPicker.onChangeProblemCheckBox, but i get ID first check. Why? Can help me anybody?

onChangeProblemCheckBox: function(id) {
    if ($('#CheckBox' + id).attr("checked") == true) {
        problemPicker.addToCheckProblems(id);

        var checkboxes = $('.jProblemClass:checked');

        if ((checkboxes.length > general.limit) && (general.limit != 0)) {
            alert('The limit of ' + general.limit + ' problems exceeded. Please deselect ' + (checkboxes.length - general.limit).toString() + '.');
        }
    } else {
        problemPicker.delFromCheckProblems(id);
    }
},

Upvotes: 8

Views: 37930

Answers (5)

Jorge Luis Romano
Jorge Luis Romano

Reputation: 161

<input class="jProblemClass" id="Checkbox{%= ID %}" type="checkbox" value="1" onchange="problemPicker.onChangeProblemCheckBox('{%=ID %}');"/>

You have to specify a value for value. Example value="1". Onchange for checkbox will change the value to 1 when checked and "" to when not checked. If you don't specify a value onchange doesn't work.

Upvotes: 0

Marcos Baiadori
Marcos Baiadori

Reputation: 1

very simple : Use onClick instead and defaultChecked to fill input.

Upvotes: 0

Tami
Tami

Reputation: 586

Bro use onclick event instead onchange.. Reason... According to the Javascript references I've read, onchange fires after the focus is lost. Unless you click somewhere else, the focus is not lost in IE. The other browsers must not be waiting for the focus to be lost before firing onchange - which suggest they are not following the spec correctly (despite it making more sense to fire at that point). How about using onclick and onkeydown/onkeyup instead (by using both onclick and onkeyup/onkeydown you cover both mouse and keyboard setting of the checkbox). REFERENCE : http://www.winvistatips.com/re-onchange-event-checkbox-not-working-properly-t311364.html

Upvotes: 26

shybovycha
shybovycha

Reputation: 12275

I think, the problem goes from here: $('#CheckBox' + id).attr("checked") == true. Accordingly to HTML specs, checked should be set to "checked" when this event fires. So, try using something like $('#CheckBox' + id).attr("checked") == "checked" or even $('#CheckBox' + id).attr("checked").

As a second option, i recommend you to use pure jquery to run your routine. For example, if you have <input type="checkbox" id="ac"> checkbox, you can use this jq code to handle your routines:

$(document).ready(function() {
    $("input[type=checkbox]").change(function() {
        alert("Am i checked? - " + $(this).attr("checked") + "\nMy ID:" + $(this).attr("id"));
    });
});

This case is shown in this demo.

Upvotes: 1

David M&#229;rtensson
David M&#229;rtensson

Reputation: 7620

Try using if($('#CheckBox' + id + ':checked').length > 0) instead, that way you led jQuery figure out it the checkbox is checked or not.

Also if the onChangeProblemCheckBox uses any internal properties in problemPicker but does not referens them with full path, ie problemPicker.nnnnnit will fail as the event will fire in the context of the element, not problemPicker. It would be as if the function was called like this $('#CheckBox' + id).onChangeProblemCheckBox().

Upvotes: 0

Related Questions