CODEWITHSUNDEEP
c++templatesstliteratorvalue-type
Hybesis
Hybesis

Reputation: 127

STL Iterator Inheritance : 'value_type' does not name a type

I am stuck trying to understand where this error comes from:

error: ‘value_type’ in ‘struct std::iterator_traits<sha::Vector<int>::h_iterator>’ does not name a type

I am trying to create a std::vector wrapper and inherit iterator as well. I don't get why the compilator cannot infer the 'value_type' or 'difference_type'.

Here is my class definition:

  template <typename T>
  class Vector
  {
    public:
    explicit Vector(std::initializer_list<T> init) : data(init) {}
    ~Vector() {}

  class h_iterator : std::iterator<std::random_access_iterator_tag, T>
  {
    public:
      h_iterator(typename std::vector<T>::iterator it,
                 Vector<T>* owner) :
        it(it), owner(owner) {}

      T operator *() const { return *it; }
      const h_iterator &operator ++() { ++it; return *this; }
      h_iterator operator ++(int) { h_iterator copy(*this); ++it; return copy; }
      const h_iterator &operator --() { --it; return *this; }
      h_iterator operator --(int) { h_iterator copy(*this); --it; return copy; }
      h_iterator& operator =(const h_iterator& other){ this->it =other.it; return *this;}

      bool operator ==(const h_iterator &other) const { return it == other.it; }
      bool operator !=(const h_iterator &other) const { return it != other.it; }
      bool operator  <(const h_iterator &other) const { return it  < other.it; }
      bool operator  >(const h_iterator &other) const { return it  > other.it; }
      bool operator <=(const h_iterator &other) const { return it <= other.it; }
      bool operator >=(const h_iterator &other) const { return it >= other.it; }

      h_iterator operator +(const long int &delta) const
      {
        h_iterator copy(*this);
        it += delta;
        return copy;
      }

      h_iterator& operator +=(const long int& delta)
      {
        it = it + delta;
        return *this;
      }

      h_iterator operator -(const long int &delta) const
      {
        h_iterator copy(*this);
        it -= delta;
        return copy;
      }

      h_iterator& operator -=(const long int& delta)
      {
        it = it - delta;
        return *this;
      }

      T operator [](const long int &delta) const { return *(it + delta); }

    private:
      typename std::vector<T>::iterator it;  // Iterator
      Vector<T>* owner;                      // Cannot be null as long as the iterator is valid
  };

  // Preserve normal iterator accesses
  typename std::vector<T>::iterator begin() { return data.begin(); }
  typename std::vector<T>::iterator end() { return data.end(); }

  const typename std::vector<T>::iterator cbegin() const { return data.cbegin(); }
  const typename std::vector<T>::iterator cend() const { return data.cend(); }

  // Observale iterator
  h_iterator h_begin() { return h_iterator(data.begin(), this); }
  h_iterator h_end() { return h_iterator(data.end(), this); }

  // Implement Meta-Language functions
  //...

private:
  Vector() {}
  Vector operator=(Vector&) {} // Not Implemented

  std::vector<T> data;            // Vector wrapper
};

Here is the code that makes the compilation failed:

typedef Vector<int> Container;
typedef Container::h_iterator IT;
typedef std::less<typename 
std::iterator_traits<Vector<int>::h_iterator>::value_type> Compare;

Why does this compile error happen?

Upvotes: 0

Views: 716

Answers (1)

R Sahu
R Sahu

Reputation: 206687

When you use:

class h_iterator : std::iterator<std::random_access_iterator_tag, T>

the base class is a private base class. The details of the base class are not accessible to clients of h_iterator. Make the derivation public.

class h_iterator : public std::iterator<std::random_access_iterator_tag, T>

Upvotes: 5

Related Questions