alc95
alc95

Reputation: 39

Classes and inheritance in Python 3.6 (Spyder)

I have beginner Python question. I have a superclass called "Animal", and I'm using inheritance to create a "Dog" class.

 class Animal:
    __name = ""
    __height = 0
    __weight = 0
    __sound = 0

    #constructor
    def __init__(self, name, height, weight, sound):
        self.__name = name
        self.__height = height
        self.__weight = weight
        self.__sound = sound

    def set_name(self,name):
        self.__name = name

    def get_name(self):
        return self.__name

    def set_height(self,height):
        self.__height = height

    def get_height(self):
        return self.__height

    def set_weight(self,weight):
        self.__weight = weight

    def get_weight(self):
        return self.__weight

    def set_sound(self,sound):
        self.__sound = sound

    def get_sound(self):
        return self.__sound

    def get_type(self):
        print("Animal")

    def toString(self):
        return "{} is {} cm tall and {} kg and says 
{}".format(self.__name,self.__height,self.__weight,self.__sound)

human = Animal("Rover",55,25,"woof")

print(human.toString())

#Inheritance
class Dog(Animal):
    __owner = "" #Inherit all variables from Animal class. Add an owner 
 variable. Every dog class has an owner variable, but not every
             #animal class has an owner variable.

    #overwrite the constructor 
    def __init__(self, name, height, weight, sound, owner):
        self.__owner = owner
        super(Dog,self).__init__(name, height, weight, sound) #let Animal 
superclass handle the other variables.

    def set_owner(self,owner):
        self.__owner = owner

    def get_owner(self):
        return self.__owner

    def get_type(self):
        print("Dog")

    def toString(self):
        return "{} is {} cm tall and {} kg and says {}. His owner is 
{}".format(self.__name,self.__height,self.__weight,self.__sound,self.__owner)

 myDog = Dog("Rover",55,25,"woof","Alex")

 print(myDog.toString())

I am getting the following error:

AttributeError: 'Dog' object has no attribute '_Dog__name'

Is the Dog subclass somehow not able to inherit the name variable from the Animal superclass?

I'm using Python 3.6 with Spyder 3.2.3

Upvotes: 1

Views: 550

Answers (1)

Daniel Roseman
Daniel Roseman

Reputation: 599866

You don't do any of this in Python. Whoever is teaching you programming appears to want to write Java, not Python. In Python you write only this:

class Animal:
    def __init__(self, name, height, weight, sound):
        self.name = name
        self.height = height
        self.weight = weight
        self.sound = sound

    def __str__(self):
        return "{} is {} cm tall and {} kg and says {}".format(self.name,self.height,self.weight,self.sound)


class Dog(Animal):
    def __init__(self, name, height, weight, sound, owner):
        self.owner = owner
        super(Dog,self).__init__(name, height, weight, sound)

    def __str__(self):
        return "{} is {} cm tall and {} kg and says {}. His owner is  {}".format(self.name,self.height,self.weight,self.sound,self.owner)


my_dog = Dog("Rover",55,25,"woof","Alex")
print(my_dog)

Upvotes: 2

Related Questions