user2182349
user2182349

Reputation: 9782

Symfony 4 - KNP Menu - MenuBuilder not being called

I am upgrading from Symfony 3.3 to Symfony 4.

KNPMenu was running fine under Symfony 3.3, but now I am seeing this exception:

An exception has been thrown during the rendering of a template ("The menu "main" is not defined.").

services.yaml

App\Menu\MenuBuilder:
    public: true
    tags:
        - { name: app.menu_builder.admin, method: createAdminMenu, alias: admin }
        - { name: app.menu_builder.calendar, method: createCalendarMenu, alias: calendar }
        - { name: app.menu_builder.main, method: createMainMenu, alias: main }
        - { name: app.menu_builder.trailer, method: createTrailerMenu, alias: trailer }
        - { name: app.menu_builder.user, method: createUserMenu, alias: user }

MenuBuilder

Namespace App\Menu;

use Knp\Menu\FactoryInterface;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerAwareTrait;
use Symfony\Component\Security\Core\Security;

class MenuBuilder implements ContainerAwareInterface
{

    use ContainerAwareTrait;

    private $factory;

    /**
     * @param FactoryInterface $factory
     */
    public function __construct( FactoryInterface $factory )
    {
        $this->factory = $factory;
    }

I put a die('here'); in the __construct, it is never executed.

Using php bin/console debug:container menu yields:

Information for Service "App\Menu\MenuBuilder"
==============================================

 ---------------- ------------------------------------------------------------------------- 
  Option           Value                                                                    
 ---------------- ------------------------------------------------------------------------- 
  Service ID       App\Menu\MenuBuilder                                                     
  Class            App\Menu\MenuBuilder                                                     
  Tags             app.menu_builder.admin (method: createAdminMenu, alias: admin)           
                   app.menu_builder.calendar (method: createCalendarMenu, alias: calendar)  
                   app.menu_builder.main (method: createMainMenu, alias: main)              
                   app.menu_builder.trailer (method: createTrailerMenu, alias: trailer)     
                   app.menu_builder.user (method: createUserMenu, alias: user)              
  Public           yes                                                                      
  Synthetic        no                                                                       
  Lazy             no                                                                       
  Shared           yes                                                                      
  Abstract         no                                                                       
  Autowired        yes                                                                      
  Autoconfigured   yes                                                                      
 ---------------- ------------------------------------------------------------------------- 

How can I get MenuBuilder __construct to execute?

Upvotes: 0

Views: 1402

Answers (1)

user2182349
user2182349

Reputation: 9782

Thank you all for your time.

This gist was helpful: https://gist.github.com/lsv/4d8044d21819f28f0dde52a3fb8211a0

This answer was helpful: How to avoid "knp_menu.factory" deprecation?

services.yaml

app.menu_builder:
    class: App\Menu\MenuBuilder

app.menu.main:
    class: Knp\Menu\MenuItem
    factory: ['@app.menu_builder', 'createMainMenu']
    arguments: { $options: [] }
    tags:
    - { name: knp_menu.menu, alias: main }

I used php bin/console debug:autowiring security to get the security authorization checker

Then I updated MenuBuilder.php like so:

Namespace App\Menu;

use Knp\Menu\FactoryInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

class MenuBuilder
{

    private $factory;
    private $security;

    /**
     * @param FactoryInterface $factory
     */
    public function __construct( FactoryInterface $factory, AuthorizationCheckerInterface $security )
    {
        $this->factory = $factory;
        $this->security = $security;
    }

Adding the SecurityAuthorizationChecker allows me to control the menu items offered with this statement:

if( $this->security->isGranted( 'IS_AUTHENTICATED_FULLY' ) )

Upvotes: 1

Related Questions