CODEWITHSUNDEEP
node.jsexpressroutes
Cuckoo
Cuckoo

Reputation: 366

404 Error Express Routing

I can't work out where I'm going wrong with this simple routing task. When I go to localhost:3030/staff, I'm getting "Cannot GET /staff" and a 404 error.

Here is my setup.

app.js:

const express = require('express');
const app = express();
const port = process.env.PORT || 3030;

const staffRouter = require('./routes/staffrouter.js');

app.use('/static', express.static(__dirname + './public'));

app.use('./staff', staffRouter);

app.get('/', function(req, res) {
    res.render('index.pug');
});

app.listen(port);

I have tried using the paths "/staff" in my GET/POST requests, but that doesn't work, and isn't how it's supposed to work according to the tutorial I'm doing. I'm really stuck.

/routes/staffrouter.js:

var express = require('express');
var router = express.Router();

const staff = require('../staff').staff;
const urlEncoded = (express.urlencoded({ extended: true }));

router.get('/', function(req, res, next) {
    res.render('staff.pug', { 
        deptOptions: staff.populateSelectors('department'),
        posOptions: staff.populateSelectors('position'),
        empArray: staff.readWriteJSON()
    });
 });

// Add new staff obj
router.post('/', urlEncoded, function(req, res, next) {
    let sObj = req.body;
    let dataArray = staff.readWriteJSON();

    //console.log('data:', data);
    dataArray.push(new staff.Employee(
        sObj.fName, 
        sObj.lName, 
        sObj.staffNum, 
        sObj.department, 
        sObj.position, 
        sObj.email, 
        sObj.phone
     ));
    staff.readWriteJSON(dataArray)
    res.render('../views/staff.pug', { 
        deptOptions: staff.populateSelectors('department'),
        posOptions: staff.populateSelectors('position'),
        empArray: staff.readWriteJSON()
    });
});

module.exports = router;

Upvotes: 0

Views: 182

Answers (1)

Sanjay
Sanjay

Reputation: 1007

wrong scope change the order

app.use('/static', express.static(__dirname + './public'));
const staffRouter = require('./routes/staffrouter.js');

Upvotes: 2

Related Questions