CODEWITHSUNDEEP
c#resharper
RichK
RichK

Reputation: 11879

How does ReSharper know "Expression is always true"?

Check out the following code:

private void Foo(object bar)
{
   Type type = bar.GetType();

    if (type != null) // Expression is always true
    {   
    }
}

ReSharper claims type will never be null. That's obvious to me because there's always going to be a type for bar, but how does ReSharper know that? How can it know that the result of a method will never be null?

Type is not a struct so it can't be that. And if the method were written by me, then the return value could certainly be null (not necessarily GetType, but something else).

Is ReSharper clever enough to know that, for only that particular method, the result will never be null? (Like there's a hard-coded list of known .NET methods which will never return null.)

Upvotes: 15

Views: 6716

Answers (4)

user203570
user203570

Reputation:

JetBrains perfectly explains how ReSharper does this in their features list.

Summary from link (this particular question is about NotNullAttribute):

We have analyzed a great share of .NET Framework Class Library, as well as NUnit Framework, and annotated it through external XML files, using a set of custom attributes from the JetBrains.Annotations namespace, specifically:

StringFormatMethodAttribute (for methods that take format strings as parameters)
InvokerParameterNameAttribute (for methods with string literal arguments that should match one of caller parameters)
AssertionMethodAttribute (for assertion methods)
AssertionConditionAttribute (for condition parameters of assertion methods)
TerminatesProgramAttribute (for methods that terminate control flow)
CanBeNullAttribute (for values that can be null)
NotNullAttribute (for values that can not be null)
UsedImplicitlyAttribute (for entities that should not be marked as unused)
MeansImplicitUseAttribute (for extending semantics of any other attribute to mean that the corresponding entity should not be marked as unused)

Upvotes: 16

Daniel A. White
Daniel A. White

Reputation: 191006

GetType is not virtual. Your assumption is most likely correct in your last statement.

Edit: to answer your comment question - it can't infer with your methods out of the box.

Upvotes: 1

Jon Skeet
Jon Skeet

Reputation: 1502835

Yes, it basically has knowledge of some well-known methods. You should find the same for string concatenation too, for example:

string x = null;
string y = null;
string z = x + y;

if (z == null)
{
    // ReSharper should warn about this never executing
}

Now the same information is also becoming available via Code Contracts - I don't know whether JetBrains is hooking directly into this information, has its own database, or a mixture of the two.

Upvotes: 7

Klaus Byskov Pedersen
Klaus Byskov Pedersen

Reputation: 121017

object.GetType is not virtual, so you cannot yourself implement a version that returns a null value. Therefore, if bar is null, you will get a NullReferenceException and otherwise, type will never by null.

Upvotes: 0

Related Questions