CODEWITHSUNDEEP
c++qtqt5qgraphicsviewqgraphicsscene
Sonicpath
Sonicpath

Reputation: 241

slow response on right click contex menu in graphic scene Qt

I have set a large menu in event filter on right click with 45-50 actions inside and I find that when I right click the response to show the menu is slow I did try the same code with 5 actions in the menu and the response was fine. Is there something wrong with this way of coding on a contex menu ?

eventFilter 

 bool Editor::eventFilter(QObject *o, QEvent *e)
 { 
  Q_UNUSED (o);
 QGraphicsSceneMouseEvent *me = (QGraphicsSceneMouseEvent*) e;
 switch ((int) e->type()){

  case QEvent::GraphicsSceneMousePress:{
     switch ((int) me->button()){
         case Qt::RightButton:{
           QGraphicsItem *item = itemAt(me->scenePos());
           showContextMenu(item->scenePos().toPoint());
           return true;
         }
        //more cases here//
     }
    break;
   }
  }
  return QObject::eventFilter(o, e);
 }

showContextMenu

 void Editor::showContextMenu(const QPoint &pos)
 {
 QGraphicsItem *item =itemAt(pos);
 // Create main effe menu
 effeMenu= new QMenu("Menu");
 QString  menuStyle(
           "QMenu {"
           "border:10px };"
             //more code here
            );

effeMenu->setStyleSheet(menuStyle);

AmpMenu=effeMenu->addMenu(QIcon(":/effectImg/img/effePng/amp.png"),"Amp");
Amp1 =AmpMenu->addAction(QIcon(":/effectImg/img/effePng/amp.png"),"Amp 1");
Amp2 =AmpMenu->addAction(QIcon(":/effectImg/img/effePng/amp.png"),"Amp 2");
CabMenu=effeMenu->addMenu(QIcon(":/effectImg/img/effePng/cab.png"),"Cab");
Cab1 =CabMenu->addAction(QIcon(":/effectImg/img/effePng/cab.png"),"Cab 1");
Cab2 =CabMenu->addAction(QIcon(":/effectImg/img/effePng/cab.png"),"Cab 2"); 
.
.
.
.
//45 actions more
 connect(effeMenu, &QMenu::triggered,this,[this,&item](QAction * k){
 menuSelection(k,item);
 });

Upvotes: 1

Views: 586

Answers (2)

eyllanesc
eyllanesc

Reputation: 244132

Instead of creating a new QMenu each time you call showContextMenu you could make it a member of the class and build it once. On the other hand it is not necessary to use a signal, you could simply use the exec() method of QMenu:

*.h

class Editor: ...{
   ...
private:
   QMenu effeMenu;
}

*.cpp

Editor::Editor(...){

   effeMenu.setTitle("Menu");
   QString  menuStyle(
           "QMenu {"
           "border:10px };"
             //more code here
            );

    effeMenu.setStyleSheet(menuStyle);

    AmpMenu=effeMenu.addMenu(QIcon(":/effectImg/img/effePng/amp.png"),"Amp");
    Amp1 =AmpMenu->addAction(QIcon(":/effectImg/img/effePng/amp.png"),"Amp 1");
    Amp2 =AmpMenu->addAction(QIcon(":/effectImg/img/effePng/amp.png"),"Amp 2");
    CabMenu=effeMenu.addMenu(QIcon(":/effectImg/img/effePng/cab.png"),"Cab");
    Cab1 =CabMenu->addAction(QIcon(":/effectImg/img/effePng/cab.png"),"Cab 1");
    Cab2 =CabMenu->addAction(QIcon(":/effectImg/img/effePng/cab.png"),"Cab 2"); 
    ...
}

void Editor::showContextMenu(const QPoint &pos){
     QGraphicsItem *item =itemAt(pos);
     QAction *action = menu.exec(pos);
     menuSelection(action, item);
}

Upvotes: 1

Tomaz Canabrava
Tomaz Canabrava

Reputation: 2408

There are two things you can do to improve speed:

1 - itemAt(pos) is costly, and you are doing it twice, one in the event, and one in the showContextMenu. From what I could understand from your code you don't need the item in the event, just in the showMenu.

2 - The menu creation that you are doing is expensive: all the actions have pixmaps. this allocs memory for the QPixmap, loads, execute, dumps. Because you told us that you use around 40 actions (and really, that's too much for a menu), this can get costly.

My advice: Create a class for your menu, create one instance of it, add a setter for the current QGraphicsObject that your menu will work on, and always use that one instance.

Upvotes: 1

Related Questions