alex
alex

Reputation: 173

how to update time regularly?

function timeClock()
{
    setTimeout("timeClock()", 1000);        
    now = new Date();
    alert(now);
    f_date = now.getDate()+" "+strMonth(now.getMonth())+" "+now.getFullYear()+" / "+timeFormat(now.getHours(), now.getMinutes());
    return f_date;
}

<span class="foo"><script type="text/javascript">document.write(timeClock());</script></span>

alert(now); gives me the value every second but it is not updated in the html. How can I update the time on the html without refresh the page?

Upvotes: 17

Views: 84826

Answers (10)

Pranesh Janarthanan
Pranesh Janarthanan

Reputation: 1194

I used @soloproper setInterval concept @Ivo Wetzel overall answer, my update is all about formatting the time as required. Reduced Programming Lines

<div id="liveClock"> </div>

$(document).ready(function () {
        updateClock();
});

function updateClock() {
   document.getElementById('liveClock').innerHTML = new Date().format("dd/MMMM/yyyy hh:mm:ss tt");
}
setInterval(updateClock, 1000);

Upvotes: 0

soloproper
soloproper

Reputation: 31

Straigt Javascript time format / update

1: create month converter func 2: create time func 3: create update func 4: create outPut func

    // month converter from index / 0-11 values
function covertMonth(num){
  let months = ['Jan','Feb','Mar','Apr','May','Jun','Jul','Aug','Sep','Oct','Nov','Dec'];
  // look into index with num 0-11
  let computedRes = months[num];
  return computedRes;
}

// time func
function Time(){
   // important to get new instant of the Date referrance
  let date = new Date();
  this.time = date.toLocaleTimeString();
  this.year = date.getUTCFullYear();
  this.day = date.getUTCDate();
  this.month = date.getUTCMonth();
  this.currentTime = date.toLocaleTimeString() + ' ' + covertMonth(this.month) + ' ' + this.day + ' ' + this.year;
  return this.currentTime;
}


 function timeOutPut(){
  let where = document.getElementById('some-id');
  where.textContent = Time(); // 1:21:39 AM Dec 17 2017
}

   // run every 5secs
setInterval(timeOutPut, 5000);

Upvotes: 0

Aaron Votre
Aaron Votre

Reputation: 1740

setInterval(expression, timeout);

The function setTimeout is intended for a single timeout, so using setInterval would be a more appropriate option. SetInterval will run regularly without the additional lines that Ivo's answer has.

I would rewrite Ivo's answer as follows:

JavaScript:

function updateClock() {
  // Ivo's content to create the date.
  document.getElementById('time').innerHTML = [date, time].join(' / ')
}
setInterval(updateClock, 1000);

Try it out yourself! https://jsfiddle.net/avotre/rtuna4x7/2/

Upvotes: 6

Ivo Wetzel
Ivo Wetzel

Reputation: 46735

There are a number of mistakes in your code. Without the use of var infront of your variable declarations, you leak them into the global scope.

Also, the use of document.write is discouraged.

Here's how I would do it:

JavaScript:

function updateClock() {
    var now = new Date(), // current date
        months = ['January', 'February', '...']; // you get the idea
        time = now.getHours() + ':' + now.getMinutes(), // again, you get the idea

        // a cleaner way than string concatenation
        date = [now.getDate(), 
                months[now.getMonth()],
                now.getFullYear()].join(' ');

    // set the content of the element with the ID time to the formatted string
    document.getElementById('time').innerHTML = [date, time].join(' / ');

    // call this function again in 1000ms
    setTimeout(updateClock, 1000);
}
updateClock(); // initial call

HTML:

<div id="time"> </div>

Upvotes: 44

BenWells
BenWells

Reputation: 327

I think your setTmeout function has the wrong variables, the first one should be a function not a string, that confused me for a bit. Basically you need to write to the span tag when you run the function.

I created a jQuery version in a fiddle to demonstrate what I mean. Didn't have your strMonth function but you get the idea. I also changed the alert to console.log but you can remove that line.

http://jsfiddle.net/5JWEV/

Upvotes: 0

Abderrahmane TAHRI JOUTI
Abderrahmane TAHRI JOUTI

Reputation: 4283

I'd use setInterval rather than setTimeout:

https://developer.mozilla.org/en/DOM/window.setInterval

Upvotes: 0

Rafay
Rafay

Reputation: 31033

$('span.foo').html(f_date);

place this inside your timeclock() function

untested

    function timeClock()
    {
        setTimeout("timeClock()", 1000);        
        now = new Date();
        alert(now);
        f_date = now.getDate()+" "+strMonth(now.getMonth())+" "+now.getFullYear()+" / "+timeFormat(now.getHours(), now.getMinutes());
       $('span.foo').html(f_date);

}

Upvotes: 0

Tom Gullen
Tom Gullen

Reputation: 61729

function timeClock()
{
    setTimeout("timeClock()", 1000);        
    now = new Date();
    alert(now);
    f_date = now.getDate()+" "+strMonth(now.getMonth())+" "+now.getFullYear()+" / "+timeFormat(now.getHours(), now.getMinutes());

    document.getElementById("foo").innerHTML = f_date;

}

<span id="foo"></span>

Upvotes: -1

Tim Reddy
Tim Reddy

Reputation: 4430

There may be something in timeago jQuery plugin you can hook into, but I haven't honestly tried...

http://timeago.yarp.com/

Upvotes: 0

Yunus Eren G&#252;zel
Yunus Eren G&#252;zel

Reputation: 3088

x = document.getElementsByTagName('SPAN').item(0);
x.innerHTML = f_date;

try putting this code block instead of return statement, i haven't test it but it will probably work

Upvotes: 0

Related Questions