CODEWITHSUNDEEP
phplaraveleloquent
Mike Thrussell
Mike Thrussell

Reputation: 4525

Laravel Eloquent - building 'where not' query with relationship

I have 5 database rows with the same client_id, 3 labelled completed, Yes.

This code pulls through 3 results as expected:

$indGoal = $client->indGoal()->where('completed','=','Yes')->get();

This code pulls through no results: I would expect 2.

$indGoal = $client->indGoal()->where('completed','!=','Yes')->get();

This question suggests adding ->orWhereNull('completed') - which works, but ignores the client_id relationship. The request brings through all non-Yes results, regardless of $client

My Client model for reference:

public function indGoal()
{
    return $this->hasMany('App\Models\IndGoal');
}

Upvotes: 0

Views: 121

Answers (1)

Jerodev
Jerodev

Reputation: 33196

You should group orWhere filters in a callback so they don't interfere with existing filters.

$indGoal = $client->indGoal()
    ->where(function ($query) {
        $query->orWhere('completed', '!=', 'yes')
            ->orWhereNull('completed');
    })
    ->get();

This way, the query builder knows any of the grouped conditions should be true and all other conditions are independent.

Upvotes: 1

Related Questions