CODEWITHSUNDEEP
phplaravel
user9985808
user9985808

Reputation:

ErrorException in Laravel Undefined variable

I am new to Laravel and I am using Relations now, but I am getting an error as

ErrorException :Undefined variable: users (View: D:\Softwares\WampServer\www\LaravelRelations\resources\views\users\index.blade.php)

Controller is in usersController.php

public function index()
{
    $users = \App\User::all();
    return view('users.index', compact($users));
}

Route is defined in web.php

Route::resource('users', 'usersController');

Models are User.php and Role.php as

<?php
//User.php
namespace App;

use Illuminate\Database\Eloquent\Model;

class User extends Model
{
    public function role() {
        return $this->belongsTo('\App\Role');
    }
}


<?php
//Role.php
namespace App;

use Illuminate\Database\Eloquent\Model;

class Role extends Model
{
    public function user() {
        return $this->hasMany('\App\User');
    }
}

and here's the index.blade.php in users folder as

<!DOCTYPE html>

<html>
    <head>
        <title></title>
    </head>
    <body>
        <ul>
            <?php
                foreach ($users as $user) {
                    echo "<li>" . $user->username . "is" . $user->role->role_name;
                }
            ?>
        </ul>
    </body>
</html>

The error is in this line foreach ($users as $user) { in $users variable

Upvotes: 1

Views: 10177

Answers (2)

Davit Zeynalyan
Davit Zeynalyan

Reputation: 8618

Wrong part of your code is compact($users) It must be compact('users'). Fixed code is

public function index()
{
    $users = \App\User::all();
    return view('users.index', compact('users');
}

compact('users') is equivalent ['users' => $users]

Upvotes: 4

Stranger
Stranger

Reputation: 134

Try this

public function index()
{
    $users = \App\User::all();
    return view('users.index', ['users' => $users] );
}

Upvotes: 1

Related Questions