CODEWITHSUNDEEP
androidandroid-recyclerview
Ezzy
Ezzy

Reputation: 1483

Horizontal RecyclerView follows first item height with wrap_content

I have a RecyclerView with a horizontal layout. The height of the individual adapter items can depend on the content of the item.

So in theory it can look like the following:

enter image description here

The problem I have now is that it wrap_content only seems to care about the height of the first problem, because the result I am getting looks like this:

enter image description here

Where as you can see that the 4th item gets cut off. However, it works perfectly if I put the tallest item first.

And to get rid of the obvious solution; I don't know the height of the items. I could only do that during testing.

--

adapter_item.xml

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="100dp"
    android:layout_height="wrap_content"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:orientation="vertical"
    android:animateLayoutChanges="true"
    android:padding="@dimen/padding_view_small">

    <ImageView
        android:id="@+id/image"
        android:layout_width="50dp"
        android:layout_height="50dp"
        android:layout_gravity="center_horizontal"
        app:srcCompat="@drawable/flamme"/>

    <TextView
        android:id="@+id/name"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:textColor="@color/black"
        android:layout_marginTop="@dimen/padding_view_small"
        android:text="@string/placeholder"
        android:gravity="center_horizontal"/>

</LinearLayout>

parent.xml

<LinearLayout
    android:id="@+id/symbol_list_parent"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="horizontal"
    android:background="@drawable/container_content"
    android:padding="@dimen/padding_view_normal">

    <android.support.v7.widget.RecyclerView
        android:id="@+id/symbol_list"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:orientation="horizontal"/>

</LinearLayout>

Activity.java

...
final ProductPictogramAdapter symbolAdapter = new ProductPictogramAdapter();
final View symbolListParent = findViewById(R.id.symbol_list_parent);
RecyclerView symbolList = findViewById(R.id.symbol_list);
symbolList.setLayoutManager(new LinearLayoutManager(ProductDetailActivity.this, LinearLayoutManager.HORIZONTAL, false));
symbolList.setAdapter(symbolAdapter);
symbolList.setHasFixedSize(true);

Upvotes: 27

Views: 7228

Answers (4)

january
january

Reputation: 59

Try this.

mRecyclerView.addOnScrollListener(new RecyclerView.OnScrollListener() {
    @Override
    public void onScrollStateChanged(@NonNull RecyclerView recyclerView, int newState) {
        super.onScrollStateChanged(recyclerView, newState);
        final int newHeight = recyclerView.getMeasuredHeight();
        if (0 != newHeight && minHeight < newHeight) {
        // keep track the height and prevent recycler view optimizing by resizing
            minHeight = newHeight;
            recyclerView.setMinimumHeight(minHeight);
        }
    }
});

Upvotes: 3

Yasin Ege
Yasin Ege

Reputation: 723

i faced the same error i solved with following code;

binding.recyclerView.setHasFixedSize(false);

Upvotes: -1

Ezzy
Ezzy

Reputation: 1483

Since this question is getting quite a lot of traction and I only posted my personal solution in the comments I'll submit an answer as well.

--

I decided to use Google's Flexbox layout library to achieve what I wanted. It's very customizable and I would recommend it to people who are trying to solve similar problems.

Upvotes: 1

Mani Vasagam
Mani Vasagam

Reputation: 820

change your imageview height as wrap_content. I'm not sure, try like that.

Upvotes: -1

Related Questions