CODEWITHSUNDEEP
c#events
michael
michael

Reputation: 15302

Why assign a handler to an event before calling it?

Basically, I've seen this used all to often:

    public event MyEventHandler MyEvent;

    private void SomeFunction()
    {
        MyEventHandler handler = this.MyEvent;

        if (handler != null)
        {
            handler(this, new MyEventArgs());
        }
    }

When it could just as easily be done like so:

    public event MyEventHandler MyEvent;

    private void SomeFunction()
    {
        if (MyEvent != null)
        {
            MyEvent(this, new MyEventArgs());
        }
    }

So, am I missing something? Is there some reason people assign the event to a handler, then raise the handler instead of the event itself? Is it just "best practice"?

Upvotes: 12

Views: 1742

Answers (2)

Oded
Oded

Reputation: 499132

The assignment to a local variable ensures that if the event gets unregistered between the if and the actual invocation, the invocation list will not be null (since the variable will have a copy of the original invocation list).

This can easily happen in multithreaded code, where between checking for a null and firing the event it may be unregistered by another thread.

See this SO question and answers.

Upvotes: 13

Marty
Marty

Reputation: 7522

Thread safety.

What happens if between the time you check if MyEvent is null and you fire MyEvent, another thread comes along and unsubscribes from the event?

Upvotes: 2

Related Questions