Reza Paidar
Reza Paidar

Reputation: 883

Issue with compare dates in where clause in dbml linq

I'm using DBML to linq search in my application. I Designed advanced search queries with DynamicLibrary.cs related to this article:
Dynamic query with Linq
So I Create a dbml and use it for my advanced linq search without extra connecting to the database. I don't have any problem with datatypes except date datatype.

This is my whereClause() function that I use it.

private string whereClause()
{
    string strWhere = string.Empty;
    if (rbvalveStreet.Checked)
    {
        if (!string.IsNullOrEmpty(valveStreet.Text))
        {
            strWhere += " valveStreet.Contains(\"" + valveStreet.Text + "\") AND ";
        }
    }

    if (rbhealth.Checked)
    {
        strWhere += " health = " + health.SelectedIndex.ToString() + " AND ";
    }
    if (rbleak.Checked)
    {
        strWhere += " leak = " + leak.SelectedIndex.ToString() + " AND ";
    }
    if (chbDateRange.Checked)
    {
        string fromDate = clsEasy.makeDate8((DateTime)dtsFrom.Value); //ex: 2018/07/30
        string toDate = clsEasy.makeDate8((DateTime)dtsTo.Value); //ex: 2018/08/05
        strWhere += " washdate >= " + fromDate + "  && washdate <= "+ toDate + " AND ";
    }
    string[] remove = { " AND " };
    foreach (string item in remove)
    {
        if (strWhere.EndsWith(item))
        {
            strWhere = strWhere.Substring(0, strWhere.LastIndexOf(item));
            break; //only allow one match at most
        }
    }

    return strWhere;
}

I want add to strWhere a linq query with search between to dates when chbDateRange is Checked. But I get this error:
 error 1[2]
Also washdate column's datatype is Date and I try the following code either:

DateTime fromDate =  DateTime.Parse(clsEasy.makeDate8((DateTime)dtsFrom.Value));
DateTime toDate = DateTime.Parse(clsEasy.makeDate8((DateTime)dtsTo.Value));
strWhere += " washdate >= " + fromDate + "  && washdate <= "+ toDate + " AND ";


and get this another error:
error 2

I'm sure a data type conflict occurred here. please Help me to resolve this problem. Thanks.

Edited:

clsEasy.makeDate8((DateTime)dtsFrom.Value) retrun date as string for example "2018/07/30"

Edited 2:
This is how I use whereClause() for Linq DBML:

private void btnFind_Click(object sender, EventArgs e)
    {
        string wClause = this.whereClause();
        if (!string.IsNullOrEmpty(wClause))
        {
            string address = "Data Source=.;Initial Catalog=valveManagement2018;Integrated Security=True";
            dgv.DataSource = null;
            refreshData();
            contextLinqDataContext cxt = new contextLinqDataContext(address);
            var query = cxt.tblValveExpirations
                        .Where(wClause);
            _dt = null;
            _dt = LINQToDataTable(query);
            refreshForm();
            countRows();
        }
        else
        {
            refreshData();
            refreshForm();
            countRows();
        }
    }

Upvotes: 0

Views: 144

Answers (1)

Panagiotis Kanavos
Panagiotis Kanavos

Reputation: 131423

You don't need to create a SQL string to add filters dynamically. You can chain multiple .Where() calls to create the equivalent of (Condition1 && Condition2 && Condition3).

Assuming the original query is stored in a variable called query you could write something like this :

IQueryable<MyEntity> query = ....;

if (rbvalveStreet.Checked && !string.IsNullOrEmpty(valveStreet.Text))
{
    var searchText=valveStreet.Text;
    query=query.Where(item=>item.valveStreet.Contains(searchText);
}
if (rbhealth.Checked)
{
    //Do we really want the *indexes*?
    //SHouldn't this be the selected text/value?
    var healthIdx=health.SelectedIndex;
    query = query.Where(itme=>item.health = healthIdx);
}
if (rbleak.Checked)
{
    var leakIdx=leak.SelectedIndex;
    query = query.Where(item=>item.leak = leakIdx);
}
if (chbDateRange.Checked)
{
    //No need to cast if this is a DateTimePicker control
    DateTime fromDate = dtsFrom.Value; 
    DateTime toDate = dtsTo.Value; 

    query = query.Where(item=> item.washdate >=fromDate
                            && item.washdate<= toDate)
}

The final query will have all specified criteria combined with an AND operator

Upvotes: 1

Related Questions