Updating Parent State Dynamically

Question

I am trying to update my parent compenent's state according to child's component input value and render components again.

I have App, Map and ListPlaces components. Map component shows the map and markers and takes markers from App component as a prop.

ListPlaces component has own state(searchQuery) and a method(updateQuery). Basically it uses regexp and filter the results according to the input and show filtered values in the list element. It's fine, however, I need much more than this. What I want to do here? According to input value changes, I want to update my markers (state in App component) and re-render my map component again to show only related markers on the map. Idea is basic, but I couldn't implement it.

When I try to change my markers which is actually array, it would be 0. I will share my all code but I need to say that I think the problem probably is about onChange method in the input element (ListPlaces)

App.js

class App extends Component {
    constructor(props) {
        super(props);
        this.state = {
            places: [],
            markers: [],
            markerID: -1,
            newmarkers: []
        };

        this.changeMarkers = this.changeMarkers.bind(this);
    }

    componentDidMount() {
        fetch(
            "api_url"
        )
            .then(response => response.json())
            .then(data => {
                this.setState({
                    places: data.response.venues,
                    markers: data.response.venues
                });
            })
            .catch(error => {
                console.log("Someting went wrong ", error);
            });
    }

    openInfo = (e, id) => {
        this.setState({
            markerID: id
        });
    };

    closeInfo = () => {
        this.setState({
            markerID: -1
        });
    };

    changeMarkers = newValue => {
        const newmarkers = this.state.places.filter(
            place => place.name === newValue
        );
        this.setState({
            markers: newmarkers
        });
    };

    toggleListPlaces = () => {
        const nav = document.getElementById("nav-toggle");
        const body = document.getElementsByTagName("body")[0];

        nav.classList.toggle("active");

        if (body.classList.contains("show-nav")) {
            body.classList.remove("show-nav");
        } else {
            // If sidebar is hidden:
            body.classList.add("show-nav");
        }
    };

    render() {
        return (
            <div className="App">
                <Map
                    role="application"
                    places={this.state.places}
                    markers={this.state.markers}
                    openInfoHandler={this.openInfo}
                    closeInfoHandler={this.closeInfo}
                    markerID={this.state.markerID}
                    googleMapURL="map_url"
                    loadingElement={<div style={{ height: "100%" }} />}
                    containerElement={<div style={{ height: "100%" }} />}
                    mapElement={<div style={{ height: "100%" }} />}
                />
                <ListPlaces
                    toggleListHandler={this.toggleListPlaces}
                    locations={this.state.places}
                    openInfoHandler={this.openInfo}
                    changeMarkersHandler={this.changeMarkers}
                />
            </div>
        );
    }
}

export default App;

ListPlaces

class ListPlaces extends Component {
    state = {
        searchQuery: ""
    };

    updateQuery = query => {
        this.setState({ searchQuery: query});
    };

    render() {
        const { toggleListHandler, locations, openInfoHandler, changeMarkersHandler} = this.props;
        let showLocations;
        if (this.state.searchQuery) {
            const match = new RegExp(escapeRegExp(this.state.searchQuery), "i");
            showLocations = locations.filter(location =>match.test(location.name));
        } else {
            showLocations = locations;
        }

        return (
            <div>
                <aside>
                    <h2>Restaurants</h2>
                    <nav>
                        <div className="search-area">
                            <input
                                className="search-input"
                                type="text"
                                placeholder="Search Restaurant"
                                value={this.state.searchQuery}
                                onChange={e => {this.updateQuery(e.target.value); changeMarkersHandler(e.target.value)}}
                            />
                        </div>
                        <ul>
                            {showLocations.map(location => {
                                return (
                                    <li
                                        key={location.id}
                                        onClick={e =>
                                            openInfoHandler(e, location.id)
                                        }
                                    >
                                        {location.name}
                                    </li>
                                );
                            })}
                        </ul>
                    </nav>
                    <p>Information provided by Foursquare</p>
                </aside>
                <a
                    onClick={toggleListHandler}
                    id="nav-toggle"
                    className="position"
                >
                    <span />
                </a>

            </div>
        );
    }
}

export default ListPlaces;

Map

const Map = withScriptjs(withGoogleMap((props) =>

    <GoogleMap
        defaultZoom={14}
        defaultCenter={{ lat: 48.2854790, lng: -143.1407394 }}
        >
        {props.markers.map(restaurant => {
            let marker = (
                <Marker
                    id={restaurant.id}
                    key={restaurant.id}
                    name={restaurant.name}
                    position={{lat: restaurant.location.lat, lng: restaurant.location.lng}}
                    address={restaurant.location.address}
                    defaultAnimation={window.google.maps.Animation.DROP} // Should be 1 or 2 according to Stackoverflow
                    onClick={e => {props.openInfoHandler(e, restaurant.id)}}
                    animation = {props.markerID === restaurant.id && window.google.maps.Animation.BOUNCE}
                    >
                    {props.markerID === restaurant.id && (
                    <InfoWindow onCloseClick={e => {props.closeInfoHandler()}}>
                      <div className="info-window">
                        <p className="restaurant-name">{restaurant.name}</p>
                        <p className="restaurant-address">{restaurant.location.address}</p>
                      </div>
                      </InfoWindow>
                        )}

                    </Marker>
                );
            return marker;
        })}

        </GoogleMap>
    ))

export default Map;

Answer 1

you're on the right track - you need to lift up the filter value/filter operation into the common parent

App.js

class App extends React.Component {
  onChangeFilter = (newFilter) => {
    this.setState({ filter: newFilter })
  }

  render () {
    const { filter, places } = this.state
    const mPlaces = places.filter(/* filter places here */)

    return (
      <div className="App">
        <ListPlaces 
          places={ mPlaces }
          onChangeFilter={ this.onChangeFilter }
          ...
        />

        <Map 
          locations={ mPlaces }
          ...
        />
      </div>
    )
  }
}

ListPlaces.js

class ListPlaces extends React.Component {
  updateQuery = (query) => {
    this.props.onChangeFilter(query)
  }

  ...
}

this is a common pattern in React - so common it has its own page in the React docs.