CODEWITHSUNDEEP
javascriptjqueryajaxjquery-events
habib
habib

Reputation: 1584

Jquery Event bound twice after ajax call

I want to bind an event on elements which are dynamically created by ajax call. Some elements are already present and an event is binds with them when page loads. But when new elements created after ajax call then new elements lose their bindings.

I searched and found a very good solution. Jquery Event won't fire after ajax call

In this question "Jason Fingar" presented two solution to fix this

Here is the first solution he presented

"1) Encapsulate your "binding" code and call it both on page load and immediately after the element in question gets added back to the page. For example:"

$(document).ready(function(){
// bind event handlers when the page loads.
bindButtonClick();
});

function bindButtonClick(){
$('.myClickableElement').click(function(){
    ... event handler code ...
});
}

function updateContent(){
$.ajax({
    url : '/ajax-endpoint.php',
    data : {'onMyWay' : 'toServer'},
    dataType : 'html',
    type : 'post',
    success : function(responseHtml){
        // .myClickableElement is replaced with new (unbound) html 
     element(s)
        $('#container').html(responseHtml);

        // re-bind event handlers to '.myClickableElement'
        bindButtonClick();  
    }
});
}

What problem I am facing? The event is bind with the new elements successfully but for the old elements or the elements which are loaded on page load, the event is bound twice. What is the problem with this?

Upvotes: 2

Views: 1817

Answers (4)

Sreeharsh Rajan
Sreeharsh Rajan

Reputation: 21

I had a similar scenario when clicking a radio button, multiple AJAX requests were triggered instead of one.

For that i implemented the following code

$(document).off('click', '.radio-class').on('click', '.radio-class', function() {
// AJAX request 
});

Upvotes: 0

31piy
31piy

Reputation: 23859

jQuery doesn't check if an event listener is already bound to an element before binding listener for the same event. In your code, .myClickableElement selects all such elements, and for existing elements, duplicate listeners will be added.

By unbinding the event listeners first

One way you can fix this is to remove the listener first, and then bind it again. In this way, it will exist once for each target element.

function bindButtonClick(){
  $('.myClickableElement').off('click').on('click', function(){
    ... event handler code ...
  });
}

By using event delegation on parent element

Another (but effective) way is to use event delegation for child elements. I don't know much about your HTML, but you can do this on the parent element (.parent here is the parent for all .myClickableElement elements):

$('.parent').on('click', '.myClickableElement', function() {
  ... event handler code ...
});

This will enable event binding for those elements as well, which are not present in the DOM when this code executes. So this will be a generic solution for your problem, and you won't need to bind the listeners when the AJAX completes.

Upvotes: 8

Radonirina Maminiaina
Radonirina Maminiaina

Reputation: 7004

You have to unbind the event that is delegated for your element using unbind method, then you rebind it.

$('.myClickableElement').unbind('click').bind('click', function(){
    // action goes here
});

If there has already an attached event to your .myClickableElement you remove it by unbinding.

For better approch, check this documentation.

Upvotes: 0

Bhushan Kawadkar
Bhushan Kawadkar

Reputation: 28513

you can delegate cilck event using document.on or parent container, which will be applicable for existing as well as dynamically created elements and no need to bind it again and again from inside ajax call

$(document).ready(function(){
   // If you know that elements for which click handler required can be anywhere in the document
   /*$(document).on('click', '.myClickableElement', function(){
    ... event handler code ...
   });*/

   //If you are sure that elements to which click event handler required is belongs to container elements
   $('#container').on('click', '.myClickableElement', function(){
    ... event handler code ...
   });
});

function updateContent(){
$.ajax({
    url : '/ajax-endpoint.php',
    data : {'onMyWay' : 'toServer'},
    dataType : 'html',
    type : 'post',
    success : function(responseHtml){
        // .myClickableElement is replaced with new (unbound) html 
     element(s)
        $('#container').html(responseHtml);

        // re-bind event handlers to '.myClickableElement'
        //bindButtonClick();   -- not required to bind again
    }
});
}

Upvotes: 0

Related Questions