Delete from table in one to one relationship hibernate

Question

I'm using MySQL, Hibernate and Spring MVC in my CRUD application. I have two entities in one-to-one unidirectional relationship. When I delete User, address is still in database. The user and address are added correctly. What's wrong? I checked all the topics on stack and did not find the reason of this fail... Below is my java code and SQL scripts.

User.java

@Table
@Entity(name = "User")
public class User {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @Column(name = "id")
    private int id;

    @Column(name = "first_name")
    private String firstName;
    @Column(name = "last_name")
    private String lastName;

    @OneToOne(cascade = CascadeType.ALL)
    @JoinColumn(name = "address_id")
    private Address address;

    public User() {

    }

    public int getId() {
        return id;
    }

    public void setId(int id) {
        this.id = id;
    }

    public String getFirstName() {
        return firstName;
    }

    public void setFirstName(String firstName) {
        this.firstName = firstName;
    }

    public String getLastName() {
        return lastName;
    }

    public void setLastName(String lastName) {
        this.lastName = lastName;
    }

    public Address getAddress() {
        return address;
    }

    public void setAddress(Address address) {
        this.address = address;
    }

    @Override
    public String toString() {
        return "User [id=" + id + ", firstName=" + firstName + ", lastName=" + lastName + ", address=" + address + "]";
    }

}

Address.java

@Entity
@Table(name = "address")
public class Address {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @Column(name = "id")
    private int id;

    @Column(name = "street")
    private String street;
    @Column(name = "city")
    private String city;
    @Column(name = "zip_code")
    private String zipCode;


    public Address() {

    }

    public Address(String street, String city, String zipCode) {
        this.street = street;
        this.city = city;
        this.zipCode = zipCode;
    }

    public int getId() {
        return id;
    }

    public void setId(int id) {
        this.id = id;
    }

    public String getStreet() {
        return street;
    }

    public void setStreet(String street) {
        this.street = street;
    }

    public String getCity() {
        return city;
    }

    public void setCity(String city) {
        this.city = city;
    }

    public String getZipCode() {
        return zipCode;
    }

    public void setZipCode(String zipCode) {
        this.zipCode = zipCode;
    }

    @Override
    public String toString() {
        return "Address [id=" + id + ", street=" + street + ", city=" + city + ", zipCode=" + zipCode + "]";
    }

}

GenericService.java

public interface GenericService {

    List getAll();

    void save(T t);

    User getOne(int id);

    void delete(int id);
}

UserService.java

@Service
public class UserService implements GenericService {

    @Autowired
    private UserDAO userDao;

    @Override
    @Transactional
    public List getAll() {
        return userDao.getAll();
    }

    @Override
    @Transactional
    public void save(User user) {
        userDao.save(user);
    }

    @Override
    @Transactional
    public User getOne(int id) {
        return userDao.getOne(id);
    }

    @Override
    @Transactional
    public void delete(int id) {
        userDao.delete(id);
    }

}

AbstractDAO.java

public abstract class AbstractDAO {

    @Autowired
    public SessionFactory sessionFactory;

    protected Class entityClass;

    public AbstractDAO() {
        ParameterizedType pt = (ParameterizedType) getClass().getGenericSuperclass();
        entityClass = (Class) pt.getActualTypeArguments()[0];
    }

    public T getOne(int id) {
        Session session = sessionFactory.getCurrentSession();
        T t = session.get(entityClass, id);
        return t;
    }

    public List getAll() {
        Session session = sessionFactory.getCurrentSession();
        TypedQuery query = session.createQuery("from " + entityClass.getSimpleName(), entityClass);
        List t = query.getResultList();
        return t;
    }

    public T save(T t) {
        Session session = sessionFactory.getCurrentSession();
        session.saveOrUpdate(t);
        return t;
    }

    public void delete(int id) {
        Session session = sessionFactory.getCurrentSession();
        TypedQuery query = session.createQuery("delete from " + entityClass.getSimpleName() + " where id=:id");
        query.setParameter("id", id);
        query.executeUpdate();
    }
}

UserDAO.java

@Repository
public class UserDAO  extends AbstractDAO{

    @Autowired
    private SessionFactory sessionFactory;

    public List getAll(){
        Session session = sessionFactory.getCurrentSession();
        TypedQuery query = session.createQuery("from "+entityClass.getSimpleName(),entityClass);
        List userList = query.getResultList();
        return userList;
    }

    public User save(User user) {
        Session currentSession = sessionFactory.getCurrentSession();
        currentSession.saveOrUpdate(user);
        return user;
    }


    public void delete(int id) {
        Session session = sessionFactory.getCurrentSession();
        TypedQuery query = session.createQuery("delete from "+ entityClass.getSimpleName()+" where id=:id");
        query.setParameter("id",id);
        query.executeUpdate();
    }
}

UserController.java

@Controller
@RequestMapping("/user")
public class UserController {

    @Autowired
    private UserService userService;

    @InitBinder
    public void initBinder(WebDataBinder dataBinder) {
        StringTrimmerEditor stringTrimmerEdition = new StringTrimmerEditor(true);
        dataBinder.registerCustomEditor(String.class, stringTrimmerEdition);
    }

    @GetMapping("/list")
    public String userList(Model theModel) {
        List theUsers = userService.getAll();
        theModel.addAttribute("users", theUsers);
        return "list-users";
    }

    @GetMapping("/showFormForAdd")
    public String showFormForAdd(Model theModel) {
        User theUser = new User();
        theModel.addAttribute("user", theUser);
        return "user-form";
    }

    @PostMapping("/saveUser")
    public String saveUser(@ModelAttribute("user") User theUser, BindingResult bindingResult) {
        userService.save(theUser);
        return "redirect:/user/list";
    }

    @GetMapping("/showFormForUpdate")
    public String showFormForUpdate(@RequestParam("userId") int theId, Model theModel) {
        User user = userService.getOne(theId);
        theModel.addAttribute("user", user);
        return "user-form";
    }

    @GetMapping("/delete")
    public String deleteUser(@RequestParam("userId") int theId) {
        userService.delete(theId);
        return "redirect:/user/list";
    }

}

list-form.jsp

<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"%>
<%@ taglib prefix="fn" uri="http://java.sun.com/jsp/jstl/functions" %>
<%@page pageEncoding="UTF-8" contentType="text/html; charset=UTF-8"%>






SimpleCRUD



    
        
            SimpleCRUD
            

    

    
        
            
                

                
                    Lista użytkowników
                
                

                

                            
                                
                            
                            
                                
                            
                            Liczba użytkowników: ${fn:length(users)}

                    
                        
                            Imię
                            Nazwisko
                            Ulica
                            Miasto
                            Kod pocztowy
                            
                        
                    
                    
                        
                                ${tempUser.firstName}
                                ${tempUser.lastName}
                                ${tempUser.address.street}
                                ${tempUser.address.city}
                                ${tempUser.address.zipCode}
                                Aktualizuj | Usuń
                            

                        
                    
                    
                

                
            


        

    

    
        

        
        
            SimpleCRUD 2018

user-form.jsp

<%@ taglib prefix="form" uri="http://www.springframework.org/tags/form"%> <%@page pageEncoding="UTF-8" contentType="text/html; charset=UTF-8"%> SimpleCRUD SimpleCRUD Dodaj użytkownika Imię: Nazwisko: Ulica: Miasto: Kod pocztowy: Powrót do listy

SQL scripts

create table address ( id int(11) not null auto_increment, street varchar(45) default null, city varchar(45) default null, zip_code varchar(45) default null, primary key (id) ); create table user ( id int(11) not null auto_increment, first_name varchar(45) default null, last_name varchar(45) default null, address_id int(11) default null, primary key (id), KEY FK_ADDRESS_idx (address_id), constraint FK_ADDRESS foreign key (address_id) references address (id) );

@EDIT

Informations from Console after save user and address to database:

Hibernate: insert into address (city, street, zip_code) values (?, ?, ?) Hibernate: insert into User (address_id, first_name, last_name) values (?, ?, ?)

Information from Console after delete user and ?address? from database:

Hibernate: delete from User where id=?

After deleting the user from the table, there is no information about removing the address as above.

Ankur · Accepted Answer

If you want to delete address value as well when you delete User data, then instead of using the query, you first need to fetch the User Object based on userId, then delete the object,

So, your code for deleting the user would look something like this:

public void delete(int id) {
        User user = getOne(id); // method present in Abstract Dao class to find the object based on Id
        Session session = sessionFactory.getCurrentSession();
        session.delete(user);
    }

Delete from table in one to one relationship hibernate

@EDIT

Answers (2)

Related Questions