CODEWITHSUNDEEP
node.jsmongodbexpressmongoose
Kenny
Kenny

Reputation: 256

Mongoose findbyid() return null

I am trying to find a record in my mongo db by its id

No matter I use findbyid(), findone(id,...), it return null

here is my code. what is the solution?

const mongoose = require('mongoose');
mongoose.connect('mongodb://localhost/Movie', {useNewUrlParser: true})
.then(() => console.log('Connected to Databse'))
.catch(err => console.err('Could not connect to MongoDB', err));

var ObjectId = require('mongodb').ObjectID;

const Schema = new mongoose.Schema({
    name: String,
    author: String,
    tags: [String],
    date: Date, 
    isPublished: Boolean,
    price: Number
});

const Data = mongoose.model('Datas', Schema);

async function updateData(id){
const result = await Data.findById(id);
console.log(result);
}
updateData('5a6900fff467be65019a9001');

Upvotes: 15

Views: 25762

Answers (7)

Leonardo DiCaprio
Leonardo DiCaprio

Reputation: 1

I also had the same problem. It was simply solved by using findOne method instead of findById method of mongoose.

findOne syntax -

findOne({id: id-of-user},function(err,foundUser){
console.log(foundUser);
});

Upvotes: 0

mradex77
mradex77

Reputation: 137

After hour of searching i needed to add _id to Schema like this:

  _id: { type: Schema.Types.ObjectId },

Upvotes: 4

saurabhlahoti
saurabhlahoti

Reputation: 466

I was also facing the same issue. Then I referred to this solution Make sure the documents in the collection have _id as an Object rather than a String. If you have imported the database entries using a JSON file, just remove all the _id fields and then import it.

After importing, MongoDB will itself assign the _id values to all the entries.

Upvotes: 1

Sylvestaro
Sylvestaro

Reputation: 101

There is a simple solution to this:

Replace

const result = await Data.findById(id);

with

const result = await Data.findById(id).exec();

See Mongoose - What does the exec function do? for an explanation on what exec() does

Upvotes: 5

Pramod Batagoda
Pramod Batagoda

Reputation: 774

I had the same problem. The _id in my DB collection was a String. After I enabled mongoose debug require('mongoose').set('debug', true), I found out that the mongoose query id as ObjectId("yourId") unless we define _id in the Schema. In order to solve the problem I had to add _id:String in to mongoose schema.

const MyDataSchema = new Schema({
  _id: String,
...
...
}

Upvotes: 46

Eduardo Oliveira
Eduardo Oliveira

Reputation: 21

In my case, the imported file used to have the _id column as string, so it was messing the DB and I was no able to filter using that column.

Once I deleted the collection, removed the _id column from data file and re-imported it, the _id filtering started working fine.

Upvotes: 0

Khánh Thọ Nguyễn
Khánh Thọ Nguyễn

Reputation: 41

Check your mongodb database, if _id is storaged as String, findById(id) can not found id. FindById(id) only finds ObjectId('yourId'). You might import database by using mongoimport and including _id in JSON, it's wrong, delete _id in imported JSON.

Upvotes: 4

Related Questions