CODEWITHSUNDEEP
firebasegoogle-cloud-firestoregoogle-cloud-functions
prudhvee
prudhvee

Reputation: 13

Cloud Functions to Cloud FireStore running locally but not when deployed

I try to write a document to one of the subcollections in firestore. The code when served locally writes to firestore but when I deploy it, it doesn't write anything. 

const functions = require('firebase-functions');
const admin = require('firebase-admin');

admin.initializeApp(functions.config().firebase);
var db = admin.firestore();

exports.update = functions.https.onRequest((request, response) => {
        db.collection('emails').doc(request.query.trackingid).get()
        .then( doc => {
            if (!doc.exists) {
                console.log('No such document!');
              } else {
                var viewRef = db.collection('emails').doc(request.query.trackingid).collection('views');
                var view = {
                    when: (new Date()).toUTCString()
                };
                viewRef.add(view)
                .then(ref => {
                    console.log("Document added");
                    return;
                }).catch(err => {
                    console.log("Document creation failed", err);
                });
              }
              return;
        }).catch((err) => {
            console.log('Tracking ID not found', err);
            return;
        });
        response.sendStatus(200);
});

Upvotes: 1

Views: 826

Answers (1)

Doug Stevenson
Doug Stevenson

Reputation: 317562

You're sending a response before the work can complete. For HTTP type functions, you are obliged to send a response only after all the work is complete. Cloud Functions will forcible terminate the function after the response is sent.

Note that get() and all of the promises derived from it are asynchronous, meaning that they return immediately, with the callbacks only being called when the work is complete. And you have no guarantee about when that will be.

What your code is doing now is kicking off a get(), then immediately following up with the next line of code, which sends the response before the work is complete. When this response is sent, Cloud Functions terminates the function, and your async work may not complete.

You need to only send the response after you are sure everything is done. This involves understanding the structure of your promises in your code.

You may want to watch my video series on using promises in Cloud Functions to better understand how this works.

Upvotes: 1

Related Questions