CODEWITHSUNDEEP
javaarraysobjectequals
mobcity zkore
mobcity zkore

Reputation: 263

How to properly use equals() if comparing an object array index and an object?

According to this answer, roughly, if we had a Classroom object array of student objects, class[index] != student1. I believe this is the mistake I am making in implementing my equals method to compare the array[index] object to another object. I believed the array[index] and the object I am comparing against to be the same.

The code below shows my getNumStudents method in which I try to count the number of times a student id shows up in a class. ID represents brand shoes he or she likes (practice exercise out of lecture). This method is in my classroom object class which implements an interface. 

@Override
public int getNumStudents(T anEntry) {
    int count = 0;
    for (int index = 0; index < numberOfEntries; index++) {

       if (roster[index].equals(anEntry)) )
        {
            counter++;
        } 
    } 

    return count;
}

My equals method is as such and is implemented in the student class:

public boolean equals(Student student) {
    if (this == student)
    {
        return true;
    }
    if (student == null)
    {
        return false;
    }
    if (this.getID() != student.getID())
    {
        return false;
    }

    return true;
}

I don't know if I properly did the hashCode override but here it is (in Student class):

   @Override
    public int hashCode() {
    int result = 17;
    result = 31 * result + studentID;
    return result;
  }

I've narrowed down where the bug is to most likely here:

   if (roster[index].equals(anEntry)) )

specifically 

roster[index].equals(anEntry))

What should I call or how should I adjust my getNumStudents(T anEntry) method to properly return the number of students with a certain ID (representing a shoe type) within a Classroom object array?

Upvotes: 1

Views: 371

Answers (1)

Alexander Pogrebnyak
Alexander Pogrebnyak

Reputation: 45576

Your equals signature is wrong.

The correct signature of equals method must be as follows.

public boolean equals(Object other)

Then inside the method you should check if it is of comparable type and if you really need it to be of type Student, you have to check for this and return false otherwise.

In your case that would be a minimal change required for your implementation:

public boolean equals(Object other)
{
    if (this == other)
    {
        return true;
    }

    // This also works if `other` is `null`
    if (!(other instanceof Student))
    {
        return false;
    }

    // Now we cast it to `Student`
    final Student student = (Student) other;

    if (this.getID() != student.getID())
    {
        return false;
    }

    return true;
}

Upvotes: 2

Related Questions