CODEWITHSUNDEEP
androidmvvmviewmodel
Prasanna Narshim
Prasanna Narshim

Reputation: 798

Sharing one view model with multiple fragments

I am having some common logic which I currently have it in a Util class. Now, I want to move this logic to ViewModel class. As this util method is used in different fragments, is it a good practice to create a common view model (feature based view model) for multiple fragments. I know Google recommended to use 1 view model for 1 view. Please suggest.

Upvotes: 4

Views: 3172

Answers (2)

Kaaveh Mohamedi
Kaaveh Mohamedi

Reputation: 1795

It's better to create a viewmodel per each fragment, but it is possible to create a single viewmodel for several fragments. According to the official documents:

class SharedViewModel : ViewModel() {
    val selected = MutableLiveData<Item>()

    fun select(item: Item) {
        selected.value = item
    }
}

class MasterFragment : Fragment() {

    private lateinit var itemSelector: Selector

    // Use the 'by activityViewModels()' Kotlin property delegate
    // from the fragment-ktx artifact
    private val model: SharedViewModel by activityViewModels()

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        itemSelector.setOnClickListener { item ->
            // Update the UI
        }
    }
}

class DetailFragment : Fragment() {

    // Use the 'by activityViewModels()' Kotlin property delegate
    // from the fragment-ktx artifact
    private val model: SharedViewModel by activityViewModels()

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        model.selected.observe(viewLifecycleOwner, Observer<Item> { item ->
            // Update the UI
        })
    }
}

Upvotes: 1

Robin Bennett
Robin Bennett

Reputation: 3231

If you've got common code, you could have several viewModels that inherit from a baseViewModel, which contains the shared code.

The advantage of this over a Util class is that the shared code is only visible to ViewModels that derive from the base, and can't get confused with anything else.

Upvotes: 1

Related Questions