CODEWITHSUNDEEP
c#
Rai Vu
Rai Vu

Reputation: 1635

Which is better when check a list is null : not null or use Any

Which is better when check list is null ?

var newList;

if(newList!= null)

or newList.Any()

In the above code, sometimes I check not null and sometimes I use Any(), I don't know which one is best practice and why ?

Any advice?

Thanks in advance

Upvotes: 4

Views: 2151

Answers (3)

Pac0
Pac0

Reputation: 23174

These are not the same.

Any will throw an exception if used on a null reference.

With lists, you can think of .Any() as .Count() != 0 (*)

You may have to check for both, and you have to do the null check before calling Any() on your IEnumerable.

One way is to check them for both in one strike with the null-safe navigation ?.as in Thierry V's answer.

But sometimes you want to throw a custom Exception if you have a null value that you are not supposed to have, and treat an empty list as a correct input, so it all depends on the context.

Just remember that these are different.

(*) : as noticed in a comment, .Any() is not actually implemented as Count() == 0. For lists, it's functionally equivalent, but it's best practice to use Any() to test if an IEnumerable is empty or not, because Count() might need to go through all the elements.

Upvotes: 11

D-Shih
D-Shih

Reputation: 46239

As other answers say != null and Any() are different

I would write an extension method to make you expect.

public static class ExtenstionArray
{
    public static bool CheckAny<T>(this IEnumerable<T> list) {
        return list != null && list.Any();
    }
}

then you can use easier to check.

if(newList.CheckAny())

Upvotes: 3

Antoine V
Antoine V

Reputation: 7204

null and Any() have the different purpose.

Any is used to check your list if it contains any item.

Before calling Any, your list must be not null, it not, it throws Null exception.

Think about newList?.Any()

Upvotes: 5

Related Questions