Collectoiview.Filter does not filter the data

Question

I have a very big problem with my application written in C# WPF MVVM. When I run my app and write in EmployeeName Textbox for example letter "A" my app dynamic filter of data and then very fast my data is unfiltered.

But when I comment both ifs in EmployeeName property (This property is top of my code) Filter works fine for other Textboxes. Could you help me? Below I placed my model and xaml.

Employee.cs

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.ComponentModel;
using System.Windows;
using System.Collections.ObjectModel;
using System.Windows.Data;
using System.Windows.Threading;

namespace OneWayTwoWayBinding
{
    public class Employee : INotifyPropertyChanged
    {
        private string employeeName;
        private int? employeeID;
        private int? employeeSalary;
        private string employeeDesigner;
        private string employeeEmailID;
        private Employee selectedEmployee;
        private ICollectionView filteredCollection;
        private string dynamicSearchEmployeeName;
        private int? dynamicSearchEmployeeID;
        private int? dynamicSearchEmployeeSalary;
        private string dynamicSearchEmployeeDesigner;
        private string dynamicSearchEmployeeEmailID;
        private int isSelected;
        private string modeOfExecuting;
        private string rememberValueEmployeeName;
        private int? rememberValueEmployeeID;
        private int? rememberValueEmployeeSalary;
        private string rememberValueEmployeeDesigner;
        private string rememberValueEmployeeEmailID;
        private ObservableCollection employees;


        public string EmployeeName
        {
            get
            {
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => (String.IsNullOrEmpty(employeeName) || ((Employee)x).EmployeeName.Contains(employeeName)); // comment if
                return employeeName;
            }
            set
            {
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => (String.IsNullOrEmpty(employeeName) || ((Employee)x).EmployeeName.Contains(employeeName)); //[![enter image description here][1]][1]comment if
                employeeName = value;
                OnPropertyChanged("EmployeeName");
            }
        }
        public int? EmployeeID
        {
            get
            {
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => ((employeeID == null) || ((Employee)x).EmployeeID == employeeID);
                return employeeID;
            }
            set
            {

                employeeID = value;
                OnPropertyChanged("EmployeeID");
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => ((employeeID == null) || ((Employee)x).EmployeeID == employeeID);
            }
        }
        public int? EmployeeSalary
        {
            get
            {
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => ((employeeSalary == null) || ((Employee)x).EmployeeSalary == employeeSalary);
                return employeeSalary;
            }
            set
            {
                employeeSalary = value;
                OnPropertyChanged("EmployeeSalary");
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => ((employeeSalary == null) || ((Employee)x).EmployeeSalary == employeeSalary);
            }
        }
        public string EmployeeDesigner
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(employeeDesigner)));
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => (String.IsNullOrEmpty(employeeDesigner) || ((Employee)x).EmployeeDesigner.Contains(employeeDesigner));
                return employeeDesigner;
            }
            set
            {
                employeeDesigner = value;
                OnPropertyChanged("EmployeeDesigner");
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => (String.IsNullOrEmpty(employeeDesigner) || ((Employee)x).EmployeeDesigner.Contains(employeeDesigner));
            }
        }
        public string EmployeeEmailID
        {
            get
            {
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => (String.IsNullOrEmpty(employeeEmailID) || ((Employee)x).EmployeeEmailID.Contains(employeeEmailID));
                return employeeEmailID;
            }
            set
            {
                employeeEmailID = value;
                OnPropertyChanged("EmployeeEmailID");
                if (FilteredCollection != null)
                    FilteredCollection.Filter = x => (String.IsNullOrEmpty(employeeEmailID) || ((Employee)x).EmployeeEmailID.Contains(employeeEmailID));
            }
        }
        public ObservableCollection Employees
        {
            get
            {
                return employees;
            }
            set
            {
                employees = value;
                OnPropertyChanged("Employees");
            }
        }

        public Employee SelectedEmployee
        {
            get
            {
                if (selectedEmployee == null)
                {
                    ModeOfExecuting = "Searching / Adding Mode";
                }
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(selectedEmployee.SelectedEmployee.ToString())));
                return selectedEmployee;
            }
            set
            {
                selectedEmployee = value;

                if (selectedEmployee == null)
                {
                    ModeOfExecuting = "Searching / Adding Mode";
                    OnPropertyChanged("SelectedEmployee");
                    OnPropertyChanged("ModeOfExecuting");
                }

                if (selectedEmployee != null)
                {
                    if (selectedEmployee.EmployeeName != string.Empty)
                    {
                        RememberValueEmployeeName = selectedEmployee.EmployeeName;
                        DynamicSearchEmployeeName = RememberValueEmployeeName;

                    }
                    if (selectedEmployee.EmployeeID != null)
                    {
                        RememberValueEmployeeID = selectedEmployee.EmployeeID;
                        DynamicSearchEmployeeID = RememberValueEmployeeID;
                    }
                    if (selectedEmployee.EmployeeSalary != null)
                    {
                        RememberValueEmployeeSalary = selectedEmployee.EmployeeSalary;
                        DynamicSearchEmployeeSalary = RememberValueEmployeeSalary;
                    }
                    if (selectedEmployee.EmployeeDesigner != string.Empty)
                    {
                        RememberValueEmployeeDesigner = selectedEmployee.EmployeeDesigner;
                        DynamicSearchEmployeeDesigner = RememberValueEmployeeDesigner;
                    }
                    if (selectedEmployee.EmployeeEmailID != string.Empty)
                    {
                        RememberValueEmployeeEmailID = selectedEmployee.EmployeeEmailID;
                        DynamicSearchEmployeeEmailID = RememberValueEmployeeEmailID;
                    }

                    ModeOfExecuting = "Editing Mode";

                    OnPropertyChanged("SelectedEmployee");
                    OnPropertyChanged("ModeOfExecuting");
                    OnPropertyChanged("RememberValueEmployeeName");
                    OnPropertyChanged("DynamicSearchEmployeeName");
                    OnPropertyChanged("RememberValueEmployeeID");
                    OnPropertyChanged("DynamicSearchEmployeeID");
                    OnPropertyChanged("RememberValueEmployeeSalary");
                    OnPropertyChanged("DynamicSearchEmployeeSalary");
                    OnPropertyChanged("RememberValueEmployeeDesigner");
                    OnPropertyChanged("RememberValueEmployeeDesigner");
                    OnPropertyChanged("RememberValueEmployeeEmailID");
                    OnPropertyChanged("DynamicSearchEmployeeEmailID");
                }

                //selectedEmployee = value;
                OnPropertyChanged("SelectedEmployee");
            }
        }

        public string DynamicSearchEmployeeName
        {
            get
            {
                if (SelectedEmployee == null)
                {
                    //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show("null")));
                    EmployeeName = dynamicSearchEmployeeName;
                    //RememberValue = dynamicSearchEmployeeName;
                }
                return dynamicSearchEmployeeName;
            }
            set
            {
                dynamicSearchEmployeeName = value;
                OnPropertyChanged("DynamicSearchEmployeeName");
            }
        }
        public int? DynamicSearchEmployeeID
        {
            get
            {
                if (SelectedEmployee == null)
                {
                    EmployeeID = dynamicSearchEmployeeID;
                }
                return dynamicSearchEmployeeID;
            }
            set
            {
                dynamicSearchEmployeeID = value;
                OnPropertyChanged("DynamicSearchEmployeeID");
            }
        }
        public int? DynamicSearchEmployeeSalary
        {
            get
            {
                if (SelectedEmployee == null)
                {
                    EmployeeSalary = dynamicSearchEmployeeSalary;
                }

                return dynamicSearchEmployeeSalary;
            }
            set
            {
                dynamicSearchEmployeeSalary = value;
                OnPropertyChanged("DynamicSearchEmployeeSalary");
            }
        }
        public string DynamicSearchEmployeeDesigner
        {
            get
            {
                if (SelectedEmployee == null)
                {
                    EmployeeDesigner = dynamicSearchEmployeeDesigner;
                }
                return dynamicSearchEmployeeDesigner;
            }
            set
            {
                dynamicSearchEmployeeDesigner = value;
                OnPropertyChanged("DynamicSearchEmployeeDesigner");
            }
        }
        public string DynamicSearchEmployeeEmailID
        {
            get
            {
                if (SelectedEmployee == null)
                {
                    EmployeeEmailID = dynamicSearchEmployeeEmailID;
                }
                return dynamicSearchEmployeeEmailID;
            }
            set
            {
                dynamicSearchEmployeeEmailID = value;
                OnPropertyChanged("DynamicSearchEmployeeEmailID");
            }

        }
        public ICollectionView FilteredCollection
        {
            get
            {
                return filteredCollection;
            }
            set
            {
                filteredCollection = value;
                OnPropertyChanged("FilteredCollection");
            }
        }

        public int IsSelected
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(changedPathBinding.ToString())));
                return isSelected;
            }
            set
            {
                isSelected = value;
                OnPropertyChanged("IsSelected");
                //SelectedEmployee.EmployeeName
            }
        }

        public string ModeOfExecuting
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(modeOfExecuting.ToString())));
                return modeOfExecuting;
            }
            set
            {
                modeOfExecuting = value;
                OnPropertyChanged("ModeOfExecuting");
            }
        }
        public string RememberValueEmployeeName
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(changedPathBinding.ToString())));
                return rememberValueEmployeeName;
            }
            set
            {
                rememberValueEmployeeName = value;
                OnPropertyChanged("RememberValueEmployeeName");
            }
        }
        public int? RememberValueEmployeeID
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(changedPathBinding.ToString())));
                return rememberValueEmployeeID;
            }
            set
            {
                rememberValueEmployeeID = value;
                OnPropertyChanged("RememberValueEmployeeID");
            }
        }
        public int? RememberValueEmployeeSalary
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(changedPathBinding.ToString())));
                return rememberValueEmployeeSalary;
            }
            set
            {
                rememberValueEmployeeSalary = value;
                OnPropertyChanged("RememberValueEmployeeSalary");
            }
        }
        public string RememberValueEmployeeDesigner
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(changedPathBinding.ToString())));
                return rememberValueEmployeeDesigner;
            }
            set
            {
                rememberValueEmployeeDesigner = value;
                OnPropertyChanged("RememberValueEmployeeDesigner");
            }
        }
        public string RememberValueEmployeeEmailID
        {
            get
            {
                //Application.Current.Dispatcher.BeginInvoke(new Action(() => MessageBox.Show(changedPathBinding.ToString())));
                return rememberValueEmployeeEmailID;
            }
            set
            {
                rememberValueEmployeeEmailID = value;
                OnPropertyChanged("RememberValueEmployeeEmailID");
            }
        }


        public event PropertyChangedEventHandler PropertyChanged = null;
        virtual protected void OnPropertyChanged(string propName)
        {
            if (PropertyChanged != null)
                PropertyChanged(this, new PropertyChangedEventArgs(propName));
        }
    }
}

MainWindows.xaml

Kfir Eichenblat · Accepted Answer

The problem is that you are overriding the filter in each one of your getters. The framework may be calling these getters soon after you change the employee name, thus applying filters of other fields and overriding the name filter

Remove the filter assignments from the getters, but keep them in the setters

Collectoiview.Filter does not filter the data

Answers (1)

Related Questions