CODEWITHSUNDEEP
javaandroidfile-upload
Ashish Kanswal
Ashish Kanswal

Reputation: 166

Upload progress of files using HttpUrlConnection with multipart is super fast in android

I am trying to upload files using multipart with HttpUrlConnection POST method. The files are getting uploaded correctly and I am getting the response for that. But when I am tracking the progress, it just gives all the progress in 1 second even for files >100 MBs. It seems like the progress is for writing the file to buffer and not the network OutputStream. Calling flush() on the stream after writing each chunk of data doesn't help. Seems like flush just clears the stream to network and doesn't wait for the response before writing the next chunk.

Here's my code for uploading the file:

//Initialised in Constructor
 boundary = twoHyphens + System.currentTimeMillis() + twoHyphens;

    URL url = new URL(requestURL);
    private HttpURLConnection httpConn = (HttpURLConnection) url.openConnection();
    httpConn.setUseCaches(false);
    httpConn.setDoOutput(true);
    httpConn.setDoInput(true);
    httpConn.setRequestMethod("POST");
    httpConn.setRequestProperty("Connection", "Keep-Alive");
    httpConn.setRequestProperty("Content-Type",
            "multipart/form-data; boundary=" + boundary);

   //This method is called to upload a file
   public String uploadFile(String fieldName, File uploadFile) throws IOException, InterruptedException {
    String fileName = uploadFile.getName();
    FileInputStream fileInputStream = new FileInputStream(uploadFile);
    DataOutputStream dataOutputStream = new DataOutputStream(new BufferedOutputStream(httpConn.getOutputStream()));

    dataOutputStream.writeBytes(twoHyphens + boundary + lineEnd);
    dataOutputStream.writeBytes("Content-Disposition: form-data; name=\"" + fieldName
            + "\"; filename=\"" + fileName + "\"" + lineEnd);
    dataOutputStream.writeBytes(lineEnd);

    int bytesRead, bytesAvailable, bufferSize;
    byte[] buffer;
    int maxBufferSize = 1 * 1024 * 1024;

    //returns no. of bytes present in fileInputStream
    bytesAvailable = fileInputStream.available();

    bufferSize = 4096;
    buffer = new byte[4096];
    long size = uploadFile.length();

    bytesRead = fileInputStream.read(buffer, 0, bufferSize);

     while (bytesRead > 0) {
        int percentage = (int) ((bytesRead / (float) size) * 100);
        dataOutputStream.write(buffer, 0, bufferSize);
        dataOutputStream.flush(); //doesn't help
        bytesAvailable = fileInputStream.available();
        bytesRead = fileInputStream.read(buffer, 0, bufferSize);
    }//This finishes in 1 second

    dataOutputStream.writeBytes(lineEnd);
    dataOutputStream.writeBytes(twoHyphens + boundary + twoHyphens + lineEnd);

    int status = httpConn.getResponseCode();
    StringBuilder sb = new StringBuilder();
    BufferedReader reader = null;

    try {
        if (status == HttpURLConnection.HTTP_OK) {
            reader = new BufferedReader(new InputStreamReader(httpConn.getInputStream(), "UTF-8"));
            String line = null;
            while ((line = reader.readLine()) != null) {
                sb.append(line);
            }
        } else {
            throw new IOException("Server exception with status code: " + status);
        }
    } catch (Exception e) {

    } finally {
        if (reader != null) {
            reader.close();
            httpConn.disconnect();
        }
    }
    return sb.toString();
}

Any help or explanation on this is really appreciated.

Upvotes: 2

Views: 1435

Answers (1)

HarryQ
HarryQ

Reputation: 1423

Writing to the output stream does not actually trigger the network connection. The data upload to the server is done when you call getResponseCode() , as I have detailed in my other ansswer

Only if you have some way to ask the getResponseCode() to report progress, otherwise you have no way to monitor the progress.

Upvotes: 4

Related Questions