amol junghare
amol junghare

Reputation: 73

onBindViewHolder() not getting value

I am not fetching details in cart here is my code

 //line no 20
     public class CartAdapter extends RecyclerView.Adapter<CartAdapter.CartViewHolder> {

Context context;
List<Cart> cartList;

public CartAdapter(Context context, List<Cart> cartList) {
    this.context = context;
    this.cartList = cartList;
}

@NonNull
@Override
public CartViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
    View itemView= LayoutInflater.from(context).inflate(R.layout.cart_item_layout,parent,false);
    return new CartViewHolder(itemView);
}

@Override
public void onBindViewHolder(@NonNull CartViewHolder holder, final int position) {
    Picasso.with(context)
            .load(cartList.get(position).link)
     //line no 41       .into(holder.img_product);

    holder.txt_amount.setNumber(String.valueOf(cartList.get(position).amount));
    holder.txt_price.setText(new StringBuilder("Rs-").append(cartList.get(position).price));
    holder.txt_product_name.setText(cartList.get(position).name);
    holder.txt_sugar_ice.setText(new StringBuilder("Sugar: ")
            .append(cartList.get(position).sugar).append("%").append("\n")
            .append("Ice: ").append(cartList.get(position).ice)
            .append("%").toString());

    //Auto save item when user change amount
    holder.txt_amount.setOnValueChangeListener(new ElegantNumberButton.OnValueChangeListener() {
        @Override
        public void onValueChange(ElegantNumberButton view, int oldValue, int newValue) {
            Cart cart= cartList.get(position);
            cart.amount=newValue;

            Common.cartRepository.updateCart(cart);
        }
    });

}

@Override
public int getItemCount() {
    return cartList.size();
}

class CartViewHolder extends RecyclerView.ViewHolder
{
    ImageView img_product;
    TextView txt_product_name,txt_sugar_ice,txt_price;
    ElegantNumberButton txt_amount;


    public CartViewHolder(View itemView) {
        super(itemView);

        img_product=(ImageView)itemView.findViewById(R.id.img_product);

txt_product_name=TextView)itemView.findViewById(R.id.txt_product_name);
        txt_sugar_ice=(TextView)itemView.findViewById(R.id.txt_sugar_ice);
        txt_price=(TextView)itemView.findViewById(R.id.txt_price);
        txt_amount=(ElegantNumberButton) itemView.findViewById(R.id.txt_amount);
    }
}

}

I have selected my products after added in cart,when i press cart icon it shows error that Target must not be null. at com.developers.a_g.designapp.Adapter.CartAdapter.onBindViewHolder(CartAdapter.java:41) at com.developers.a_g.designapp.Adapter.CartAdapter.onBindViewHolder(CartAdapter.java:20)

cart_item_layout

 <?xml version="1.0" encoding="utf-8"?>
<android.support.v7.widget.CardView
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    app:cardElevation="8dp"
    >



 <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_margin="8dp"
        android:orientation="horizontal">



   <ImageView
        android:layout_width="80dp"
        android:layout_height="80dp"
        />
    <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:orientation="vertical">

        <TextView
            android:id="@+id/txt_product_name"
            android:text="Milk Tea"
            android:textSize="20sp"
            android:textStyle="bold"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            />
        <TextView
            android:id="@+id/txt_sugar_ice"
            android:text="Milk Tea"
            android:textSize="14sp"
            android:textStyle="bold"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            />

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:orientation="horizontal"
            android:weightSum="7">

            <TextView
                android:id="@+id/txt_price"
                android:text="RS-500"
                android:textSize="18sp"
                android:textStyle="bold"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_weight="6"
                />
            <com.cepheuen.elegantnumberbutton.view.ElegantNumberButton
                android:layout_width="80dp"
                android:layout_height="30dp"
                android:id="@+id/txt_amount"
                app:initialNumber="1"
                android:layout_weight="1"
                app:finalNumber="100"
                app:textSize="10sp"
                >
    </com.cepheuen.elegantnumberbutton.view.ElegantNumberButton>

    </LinearLayout>

    </LinearLayout>

  </LinearLayout>

</android.support.v7.widget.CardView>

Upvotes: 0

Views: 705

Answers (2)

Farman Ali Khan
Farman Ali Khan

Reputation: 896

You haven't given id to imageview

   <ImageView
            android:layout_width="80dp"
            android:layout_height="80dp"
            android:scaleType="fitXY"
            android:id="@+id/img_product"/>

and onCreateViewHolder will like below

 View itemView= LayoutInflater.from(parent.getContext()).inflate(R.layout.cart_item_layout,parent,false);
    return new CartViewHolder(itemView);

Upvotes: 1

Sasi Kumar
Sasi Kumar

Reputation: 13348

check link have vaild url or empty

String link=cartList.get(position).link
if(link != null){
Picasso.with(context)
        .load(link)
       .into(holder.img_product);
}

Upvotes: 0

Related Questions