CODEWITHSUNDEEP
javaexceptionnulldesign-by-contract
Royal Wares
Royal Wares

Reputation: 1272

Returning Null vs Exception vs Contract

What would be considered an acceptable way of dealing with returning a record from a DB with the following 3 potential outcomes:

  1. Db connection works, finds a user and returns a populated user object
  2. Db connection works, doesn't find a user, returns a new user object
  3. Db connection/query fails...

I'm for the most part aiming for design by contract:

class Scratch {
        public User getUser(int id) {
            try {
                // Prepare SQL Query
                PreparedStatement s = this.connection.prepareStatement(
                        "select * from get_user(?)"
                );

                // Provide SQL Parameters
                s.setInt(1, id);

                // Run our SQL
                ResultSet rs = s.executeQuery();
                rs.next();

                // Extract data into Entity
                User user = User.createFromDatabase(rs);
                rs.close();

                return user;

            } catch(Exception e) {
                e.printStackTrace();
            }

            return new User();
        }
}

In the situation that the DB connection or query fails it's a little less obvious what I should do, I have a few options:

I'm leaning towards handling Exceptions as it avoids the billion-dollar mistake, and also maintains design by contract in normal situations.

However I'd like to know if there are any obvious pitfalls or if this is a familiar situation with a well established pattern to resolve it.

Upvotes: 0

Views: 121

Answers (2)

RoberMP
RoberMP

Reputation: 1356

Use Optional (please). This make explicit that the user could not be found in the database and avoid NullPointerException's.

  • Optional(User) if the user is found in the database
  • Empty if user is not found
  • If there is an Error you have two options:
    • Notify the client so it can get feedback and react to this failure. In this case throw an exception and handle it in the proper layer. This should be the default behaviour for most of the applications.
    • Hide it to the client, this is less common but some times the client doesn't care or you don't want to publish your failures. In that case just return an Empty.

Upvotes: 0

Pieter Samoy
Pieter Samoy

Reputation: 80

I would throw an exception and let the user know that the connection failed. Returning NULL is something I would never do because you won't know what the problem was.

I don't know why you would return "New user object" if you don't have connection to the database. You won't be able to save the user.

My choice will be to Throw an exception

Upvotes: 1

Related Questions