CODEWITHSUNDEEP
pythonmysqlpython-3.xstring-formatting
robots.txt
robots.txt

Reputation: 137

Python's string formatting throws error when applied within mysql

I've written a script in python to scrape some data from a website and store them in mysql. My script successfully do the job if I opt for the two options to insert the data:

mycursor.execute("INSERT INTO webdata (name,bubble,review) VALUES ('{}','{}','{}')".format(name,bubble,review))
mycursor.execute("INSERT INTO webdata (name,bubble,review) VALUES (%s,%s,%s)",(name,bubble,review))

However, It throws an error when I try to do the same using python's new string formatting like below:

mycursor.execute("INSERT INTO webdata (name,bubble,review) VALUES (f'{name},{bubble},{review}')")

Error It throws:

line 429, in _handle_result
    raise errors.get_exception(packet)
mysql.connector.errors.ProgrammingError: 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ''{name},{bubble},{review}')' at line 1

Where I'm going wrong and how to fix it as I'm very willing to stick to the last formatting style?

Upvotes: 3

Views: 1697

Answers (2)

dlink
dlink

Reputation: 1595

Better to let the MySQL Connector bind the variables, by using %s's. This avoids SQL injection. Here a working example.

import MySQLdb

# set up db connection
dbApi = MySQLdb
connection = MySQLdb.connect(
    host    = <hostname>,
    user    = <databasename>,
    passwd  = password,
    db      = <dbname>,
    port    = 3306,
    charset = "utf8")
cursor = connection.cursor(dbApi.cursors.DictCursor)

# insert records
records = [['George', 'Ten', 'Good'],
           ['Ringo', 'Ten', 'Good'],
           ['Paul', 'Ten', 'Good'],
           ['John', 'Ten', 'Good']]
insert_sql = 'insert into webdata (name, bubble, review) values (%s, %s, %s)'

for record in records:
    cursor.execute(insert_sql, record)

# list record
sql = 'select * from webdata'
cursor.execute(sql)
data = cursor.fetchall()
print 'data:', data

connection.commit()
cursor.close()

Upvotes: 4

AKX
AKX

Reputation: 168967

You can't use f-strings with databases, simple as that, if you want to write code not vulnerable to SQL injection vulnerabilities.

Upvotes: 1

Related Questions