CODEWITHSUNDEEP
c#file
Shannow
Shannow

Reputation: 199

C# run batch file, command not recognised

I have implemeneted a method into my c# program to run a batch file, which runs a virus scan on any files uploaded;

public static Int32 ExecuteCommand(String filePath, Int32 Timeout){
    Int32 ExitCode;
    ProcessStartInfo ProcessInfo = new ProcessStartInfo();
    ProcessInfo.CreateNoWindow = true;
    ProcessInfo.UseShellExecute = true;
    ProcessInfo.FileName = filePath;
    Process proc = Process.Start(ProcessInfo);
    proc.WaitForExit(Timeout);
    ExitCode = proc.ExitCode;
    proc.Close();
    return ExitCode;
 }

Ok now my batch file;

@ECHO OFF
c:
cd "..\AVG\AVG9\"
avgscana.exe /SCAN="..\learninglounge.com.solar.quarantine\" /REPORT="..\learninglounge.com.solar.antivirus\virusReports\report.txt"

EDIT : I do have fully qualified link to avg exe and directories but have replaced here with .. for purposes of posting to stackoverflow. Sorry if this caused confusion.

So my problem is the reporting side of my batch file. I can double click the batch file and it scans and creates the report no problem. When i run it through my c# i get an exit code of 2; command not recognised. It's fine if i remove the report part of my batch file. Now obviously this points to write permissions but I have checked that and the impersonated user has write access on the directory. Is there anything Im missing?

Thanks all

Upvotes: 3

Views: 1292

Answers (4)

Dekker500
Dekker500

Reputation: 821

In your batch file, you have:

c:
cd "..\AVG\AVG9\"
avgscana.exe 
  /SCAN="..\learninglounge.com.solar.quarantine\"
  /REPORT="..\learninglounge.com.solar.antivirus\virusReports\report.txt"

When the command is executed, the 'current' directory on drive C: is ambiguous. You just move up the directory tree. Same with the avgscana.exe command, you make relative references instead of absolute.

Are you certain that the CD command has brought you to the correct directory? Change the CD command to an absolute reference ( cd "c:\wherever\avg\avg9\" ), and that way you can be sure your avgscana command's relative references are found.

Your CD command may be failing silently but your avgscana.exe may be in your path, so it does get executed, but since the relative /scan and /report locations are not found, it fails with a code 2.

Good luck!

Upvotes: 0

Shannow
Shannow

Reputation: 199

Ok well ive done a work around, id rather have saved the report there and then but instead i just catch the standard output from the process and then save to a file + any processing.

Weird one this.

Upvotes: 0

Snowbear
Snowbear

Reputation: 17274

The error states that avgscana.exe isn't located in directory which is set as "current" when you execute command. When you click on your bat file in Windows Explorer current directory is set to directory where bat file is located. Probably your avgscana.exe is located in the same folder so it works fine.

When you execute the command from .Net application current directory remains the same (if you haven't changed it then it will be a folder where .Net app is located). If your .Net app is located not in the same folder as bat file then you will get an error which you're actually getting. You should either specify a full path in your bat file or set Environment.CurrentDirectory in .Net app before launching bat.

Upvotes: 1

luckyluke
luckyluke

Reputation: 1563

HAve You checked that all enviromental variables are set exactly the same as You run the batch file from cmd line. I am pretty sure that there might be some differences. Also what kind of operating system is it. If this requires elevation (vista windows 7) You might actually need to impersonate appropriate user in code. luke

Upvotes: 0

Related Questions