CODEWITHSUNDEEP
androidgoogle-maps-android-api-2
user10405291
user10405291

Reputation: 41

App is crashing when calling moveCamera Google maps

I am trying to call moveCamera and my App is crashing. I am receiving a latlng from an Intent extra. I know the extra is coming throungh because I print it updates an edittext. I have tried entering different coordinates myself and nothingis working. Here is my error

 E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.mmitm, PID: 28348
java.lang.RuntimeException: Unable to resume activity {com.example.mmitm/com.example.mmitm.MapActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.google.android.gms.maps.GoogleMap.moveCamera(com.google.android.gms.maps.CameraUpdate)' on a null object reference
    at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3645)
    at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3685)
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2898)
    at android.app.ActivityThread.-wrap11(Unknown Source:0)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593)
    at android.os.Handler.dispatchMessage(Handler.java:105)
    at android.os.Looper.loop(Looper.java:164)
    at android.app.ActivityThread.main(ActivityThread.java:6541)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
 Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.google.android.gms.maps.GoogleMap.moveCamera(com.google.android.gms.maps.CameraUpdate)' on a null object reference
    at com.example.mmitm.MapActivity.receiveData(MapActivity.java:136)
    at com.example.mmitm.MapActivity.onResume(MapActivity.java:111)
    at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1354)
    at android.app.Activity.performResume(Activity.java:7079)
    at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3620)
    at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3685) 
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2898) 
    at android.app.ActivityThread.-wrap11(Unknown Source:0) 
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593) 
    at android.os.Handler.dispatchMessage(Handler.java:105) 
    at android.os.Looper.loop(Looper.java:164) 
    at android.app.ActivityThread.main(ActivityThread.java:6541) 
    at java.lang.reflect.Method.invoke(Native Method) 
    at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) 
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767) 

And here is my map activity where I call the movecamera

//onResume Method check which fragment intent is sent from
@Override
protected void onResume() {
    super.onResume();

    //make sure extras are not null
    Bundle extras = getIntent().getExtras();
    if (extras != null) {
        this.receiveData();
        Toast.makeText(this, "Received Data", Toast.LENGTH_SHORT).show();

    }
}

private void receiveData() {
    //RECEIVE DATA VIA INTENT
    Intent i = getIntent();

    if(i != null)
    {
        LatLng locationOne = i.getParcelableExtra("LOC_ONE");
        LatLng locationTwo = i.getParcelableExtra("LOC_TWO");

        Toast.makeText(this, "LocOne = " + locationOne + ", LocTwo = " + locationTwo, Toast.LENGTH_LONG).show();
        //SET DATA TO TEXTVIEWS
        locOne.setText(locationOne.toString());
        locTwo.setText(locationTwo.toString());
        // move camera to location one
        Log.d(TAG, "receiveData: calling moveCamera");



        //Map Crashes when trying to move camera
        mMap.moveCamera(CameraUpdateFactory.newLatLngZoom(locationOne,15));
    }
}

And my MoveCamera function

private void moveCamera(LatLng latLng, float zoom){
    Log.d(TAG, "moveCamera: moving the camera to: lat: " + latLng.latitude + ", lng: " + latLng.longitude );
    mMap.moveCamera(CameraUpdateFactory.newLatLngZoom(latLng, zoom));
}

This is my first android app so any help is appreciated!

Upvotes: 0

Views: 521

Answers (2)

Mavee Shah
Mavee Shah

Reputation: 32

You're calling moveCamera inside the function itself besides why do you need your own function when there is a built in function to do so. mMap.animateCamera(CameraUpdateFactory.newLatLngZoom(place.getLatLng(), 15.0f));

Upvotes: 0

Martin Zeitler
Martin Zeitler

Reputation: 76699

it obviously crashes, because mMap is NULL.

if(this.getIntent() != null && mMap != null) {
    ...
}

just had a closer look; you need to handle the intent onMapReady():

@Override
public void onMapReady(GoogleMap map) {

    this.mMap = map;

    if(this.getIntent() != null && this.getIntent().getAction() == INTENT_ACTION_LOCATION_SELECT) {
        /* your code goes here */
    } else {
        /* regular initialization */
    }
}

where onResume() would possibly need to obtain the map from the SupportMapFragment.

Upvotes: 1

Related Questions