CODEWITHSUNDEEP
performanceservletsjakarta-ee
Dinuk
Dinuk

Reputation: 1526

Performance tuning: Reading servlet request body

We are having a performance problem in our application - particularly when the browser client submits large volume of POST data to the server.

The bottleneck is in reading the servlet request body into a Stringbuffer - which we have observed timings above 10 seconds for large requests: (800 - 1400 KB - which, from the browsers perspective translates to anything between 800,000 - 1,500,000 characters)

        StringBuilder strBuilder = new StringBuilder(2 ^ 19);
        InputStreamReader isr = new InputStreamReader(request.getInputStream());
        BufferedReader bufReader = new BufferedReader(isr);
        char[] charBuffer = new char[2 ^ 19];

        for (int readCount = bufReader.read(charBuffer); readCount > -1; readCount = bufReader.read(charBuffer))
        {
            strBuilder.append(charBuffer, 0, readCount);
        }

Some points to note:

Yes, I have a nagging feeling there may be greater scalability issues lurking behind this problem :-).

However, before re-evaluating the design of the application, I would like to know whether there are any optimisations around this code block which I could try.

Any suggestions would be much appreciated.

Upvotes: 0

Views: 1142

Answers (2)

Dinuk
Dinuk

Reputation: 1526

The answer was glaring at me all the time...

2 ^ 19 gets compiled into 17 - as it is the bitwise exclusive OR operator, and not signed left shift :-)

There is probably a lesson to be learned here, not sure which - empirical analysis of the efficacy of peer review, or admonitions against late-night coding - I'm yet to make up my mind.

Might serve as a useful Java Puzzler though, Neal Gafter if you are reading this!

Upvotes: 0

kschneid
kschneid

Reputation: 5694

You already have an implicit buffer thanks to BufferedReader, yet you're reading from that into another buffer (char[]) before appending to the StringBuilder. Just read one char at a time from the BufferedReader and append it. I believe the default buffer size for BufferedReader is 8K, so you can always try a different size to see if that helps. Have you inspected the amount of time being spent in GC?

Upvotes: 2

Related Questions