CODEWITHSUNDEEP
ruby-on-railsrubyruby-on-rails-5
Juanse Cora
Juanse Cora

Reputation: 935

Rails 5: find_or_create_by not saving all the params

I have a form that should send info. One of the inputs is "empresa_id", and it's represented by a collection. I have checked in the server the form send the information I want. The thing is this field (only that one) is not saved when I run find_or_create_by. I've checked strong params and everything seem fine there.

SuscriptorsController

  def create
    @suscriptor = Suscriptor.new(suscriptor_params)

    byebug #In this point @suscriptor.empresa_id has a correct value
    if [email protected]?
      flash[:error] = "El email debe ser válido"
      render 'new'
    else
      @suscriptor = Suscriptor.find_or_create_by(email: @suscriptor.email)
      if @suscriptor.persisted?
        if (@suscriptor.email_confirmation == true)
          flash[:notice] = "Ya estás registrado/a"
          redirect_to root_path
        else
          SuscriptorMailer.registration_confirmation(@suscriptor).deliver
        end
      else
        flash[:error] = "Ha ocurrido un error. Contáctanos desde la sección contacto y explícanos"
        render 'new'
      end
    end


  private
  def suscriptor_params
    params.require(:suscriptor).permit(:email, :email_confirmation, :token_confirmation, :subtitle, :empresa_id)
  end

Form view

<%= simple_form_for(@suscriptor) do |f| %>

<div class="input-group">
  <div class="col-md-12">

    <div class="form-group text">
      <%= f.input :email, class: "form-control", placeholder: "[email protected]", required: true %>
      <%= f.invisible_captcha :subtitle %>
      <small id="emailHelp" class="form-text text-muted">Lo guardaremos y usaremos con cuidado.</small>

      <%= f.input :empresa_id, collection: Empresa.all %>
    </div>


    <div class="input-group-append">
      <%= f.submit "¡Hecho!", class: "btn btn-primary" %>
    </div>
  </div>
<% end %>

schema.rb

  create_table "suscriptors", force: :cascade do |t|
    t.string   "email"
    t.boolean  "email_confirmation"
    t.string   "token_confirmation"
    t.datetime "created_at",         null: false
    t.datetime "updated_at",         null: false
    t.integer  "empresa_id"
  end

suscriptor.rb

class Suscriptor < ApplicationRecord
  belongs_to :empresa, optional: true

  before_create :confirmation_token
  attr_accessor :subtitle

  VALID_EMAIL_REGEX = /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i

  validates :email, presence: true, length: { maximum: 255 }, uniqueness: { case_sensitive: false }, format: { with: VALID_EMAIL_REGEX }

  def confirmation_token
      if self.token_confirmation.blank?
          self.token_confirmation = SecureRandom.urlsafe_base64.to_s
      end
  end

end

Upvotes: 1

Views: 587

Answers (1)

Dimitrius Lachi
Dimitrius Lachi

Reputation: 1287

In your find_or_create_by, your pass only the @suscriptor.email, and reassing the @suscriptor variable with the created suscriptor.

According API dock, you should pass a block to 'create with more parameters':

Suscriptor.find_or_create_by(email: @suscriptor.email) do |suscriptor|
  suscriptor.empresa_id = @suscriptor.empresa_id
end

Be careful to not reassign @suscriptor variable before use the parameters.

You can read more about find_or_create_by in https://apidock.com/rails/v4.0.2/ActiveRecord/Relation/find_or_create_by

Hope this helps!

Upvotes: 3

Related Questions