CODEWITHSUNDEEP
bashgnome-terminal
tapan
tapan

Reputation: 1796

Weird problem in running bash script

I wrote a bash script that fetches lyrics from a website. The script is here --> http://scrippets.wordpress.com/2011/02/01/fetching-lyrics-of-songs-from-the-terminal/ (the indentations in the script are correct unlike how it looks on the blog) This script works perfectly well when executed from the terminal. Now i created a custom keyboard shortcut using compiz commands, that executes the following command when the right key combination is pressed :

gnome-terminal --working-directory="/home/tapan/sandbox/bash/" --window-with-profile=lyrics -e "/home/tapan/sandbox/bash/lyrics.sh" -t "`rhythmbox-client --print-playing`"

I created a new profile called "lyrics" to give the terminal that opens up a custom look. When i open up a terminal with this profile and run the script, it works perfectly fine again. However, when i use the keyboard shortcut to run the custom command, i get the following error:

Pink Floyd - Is There Anybody Out There?
wget: missing URL
Usage: wget [OPTION]... [URL]...

Try `wget --help' for more options.
cat: 3.txt: No such file or directory

I cannot figure out whats wrong. I mean if it works perfectly well in the terminal normally, why shouldn't this work? Any suggestions? PS: The script i have written is pretty elementary and noobish, so any suggestions to improve it are also welcome in the comments :)

EDIT: The output has changed a little, now it just shows the name of the song playing and nothing else. Though sometimes it still shows the wget error.

EDIT2: When i run that gnome terminal command from a terminal, it works. The problem is only when running it with the keyboard shortcut using compiz commands or if i use the run dialog (the alt+f2 one).

Upvotes: 0

Views: 523

Answers (2)

mob
mob

Reputation: 118605

You need to uriencode your song title so that special characters like '?', '&', '%', and '+' are not passed literally in your URL. 

name3=${name2//\?/%3F}
searchq=${name3// /+}

will handle the ?'s. I don't know of a more general solution in bash without resorting to one-line Perl or Python scripts.

Upvotes: 0

stew
stew

Reputation: 11366

The two wget commands should probably have the url variables in double quotes, for example: wget -q -U Mozilla -O 1.txt $link should be wget -q -U Mozilla -O 1.txt "$link"

Upvotes: 1

Related Questions