CODEWITHSUNDEEP
c#asp.net-core
Codrin Muntean
Codrin Muntean

Reputation: 75

ASP.NET CORE MVC SelectList from a collection of Objects

So I have these 2 classes representing tables in a local db using ef core migration in an asp.net core app

public class Teacher
{
    public int ID { get; set; }

    public string FistName { get; set; }

    public string LastName { get; set; }

    public Class Class { get; set; }

    public string FullName
    {
        get
        {
            return $"{LastName} {FistName}";
        }
    }

    public override string ToString()
    {
        return FullName;
    }
}

and

public class Class
{
    public int ID { get; set; }

    public int TeacherID { get; set; }

    public string Name { get; set; }


    public Teacher Teacher { get; set; }

    public ICollection<Student> Students { get; set; }
}

I want to add in my classes controller the functionality to create a new instance of the "Class" class by typing out a name in a textbox and selecting a teacher from a dropdownlist.

Here are my create http get & post methods

    public IActionResult Create()
    {
        var teachers = from s in _context.Teachers
                           where s.Class == null
                           select s;

        ViewData["Teachers"] = new SelectList(teachers.ToList());
        return View();
    }

    [HttpPost]
    [ValidateAntiForgeryToken]
    public async Task<IActionResult> Create(Class @class)
    {
        if (ModelState.IsValid)
        {
            @class.TeacherID = @class.Teacher.ID;
            _context.Add(@class);
            await _context.SaveChangesAsync();
            return RedirectToAction(nameof(Index));
        }
        return View("Index");
    }

and the form for submitting user-typed data

<form asp-action="Create">
        <div asp-validation-summary="ModelOnly" class="text-danger"></div>
        <div class="form-group">
            <label asp-for="Teacher" class="control-label"></label>
            <select asp-for="Teacher" class ="form-control" asp-items="ViewBag.Teachers"></select>
        </div>
        <div class="form-group">
            <label asp-for="Name" class="control-label"></label>
            <input asp-for="Name" class="form-control" />
            <span asp-validation-for="Name" class="text-danger"></span>
        </div>
        <div class="form-group">
            <input type="submit" value="Create" class="btn btn-default" />
        </div>
    </form>

I can see the right data in the dropdown list but for some reason inside the POST method @class.Teacher is null. What am I doing wrong?

Upvotes: 5

Views: 19798

Answers (4)

Xueli Chen
Xueli Chen

Reputation: 12695

Make the following changes

Create http get method , view SelectList Class , set ID to the dataValueFieldof the selectList and set FullNameto the dataTextFieldof selectList

 public IActionResult Create()
    {
        var teachers = from s in _context.Teacher
                       where s.Class == null
                       select s;

        ViewData["Teachers"] = new SelectList(teachers.ToList(),"ID","FullName");
        return View();
    }

The select tag in the form

<select asp-for="TeacherID" class="form-control" asp-items="ViewBag.Teachers"></select>

Upvotes: 3

TanvirArjel
TanvirArjel

Reputation: 32069

First update your Create GET method as follows:

public async Task<IActionResult> Create()
{
    var teachers = await _context.Teachers.Where(t => t.Class == null).ToListAsync();
    ViewData["Teachers"] = new SelectList(teachers,"ID","FullName");
    return View();
}

Then write your FormGroup for select list as follows:

<div class="form-group">
     <label asp-for="TeacherID" class="control-label">Teacher</label>
     <select asp-for="TeacherID" class ="form-control" asp-items="ViewBag.Teachers">
     </select>
     <span asp-validation-for="TeacherID" class="text-danger"></span>
</div>

Now update your Create POST method as follows:

[HttpPost]
[ValidateAntiForgeryToken]
public async Task<IActionResult> Create(Class @class)
{
    if (ModelState.IsValid)
    {
        _context.Classes.Add(@class); // now your @class is containing the `TeacheID` value selected from drop-down.
        await _context.SaveChangesAsync();
        return RedirectToAction(nameof(Index));
    }
    return View("Index");
}

Now everything should work fine!

Upvotes: 7

karritos
karritos

Reputation: 344

"Teacher" is a complex class, that will always be null, I think you're getting confused, replace "Teacher" by "teacherID". EF will do the job.

Upvotes: 0

Chris Pratt
Chris Pratt

Reputation: 239290

A select list will only return a primitive type (string, int, etc.), not an entire class instance. As a result, you'll need to bind the value to a property that is also such a primitive type. Since you already have a TeacherID property, you can just use that. When you save, EF will fixup the Teacher reference with the corresponding id.

<select asp-for="TeacherID" class ="form-control" asp-items="ViewBag.Teachers"></select>

Upvotes: 0

Related Questions