CODEWITHSUNDEEP
reactjsecmascript-6
Elena Mykhailiuk
Elena Mykhailiuk

Reputation: 33

How to setState() in loop using spread operator

I'm trying to set new values for several fields in nested object in state using spread operator in loop, but it works only for last field.

I have an array "formFields" with names of fields which values I want to overwrite. I use map() to compare each element in array with field in state and switch it's value to "true". But it change value only for the last field in array - "comment".

constructor() {
    super();
    this.state = {
        fields: {
            time: false,
            date: false,
            quantity: false,
            comment: false,
        },
    }
}

getFormFields() {
    const formFields = ["time", "quantity", "comment"];
    formFields.map(item => {
        this.setState({
            ...this.state.fields,
            [item]: true
        })
    });
}

What should I do to overwrite values for all the fields I want?

Upvotes: 3

Views: 516

Answers (1)

Ori Drori
Ori Drori

Reputation: 192016

Since you are changing state in a loop, and each state you set contains the original item with only changed, the latest change overrides the previous one. Instead, create a new state object with the change, and then setState the object once:

getFormFields() {
  const formFields = ["time", "quantity", "comment"];
  this.setState(formFields.reduce((r, item) => ({
    ...r,
    [item]: true
  }), {}));
}

btw - If the fields you want to set to true are always the same, you can create the object manually, and set it:

getFormFields() {
  this.setState({
      time: true,
      quantity: true,
      comment: true,
  });
}

Upvotes: 4

Related Questions