CODEWITHSUNDEEP
cwinapi
Sergio Calderon
Sergio Calderon

Reputation: 867

Problem getting full version number for Windows 10 with GetFileVersionInfo and VerQueryValue

I want to get the full version number for Windows, just like CMD does:

Full version number from console

I ended up with this MS doc that says:

To obtain the full version number for the operating system, call the GetFileVersionInfo function on one of the system DLLs, such as Kernel32.dll, then call VerQueryValue to obtain the \StringFileInfo\\ProductVersion subblock of the file version information.

So I tried to use those functions with this code:

#include <Windows.h>
#include <wchar.h>

#pragma comment(lib, "Mincore.lib")

int wmain(int argc, wchar_t* argv[])
{
    // GetFileVersionInfoW
    LPCWSTR fileName = L"C:\\Windows\\System32\\kernel32.dll";
    DWORD fileInfoSize;

    fileInfoSize = GetFileVersionInfoSizeW(fileName, NULL);

    if (fileInfoSize == 0)
    {
        fwprintf(stderr, L"\nError code: %u\n", GetLastError());
        return;
    }

    // GetFileVersionInfoW
    VOID* pFileVerInfo = malloc(fileInfoSize);

    if (pFileVerInfo == NULL)
    {
        fwprintf(stderr, L"Failed allocating!\n");
        return;
    }

    if (!GetFileVersionInfoW(fileName, 0, fileInfoSize, pFileVerInfo))
    {
        fwprintf(stderr, L"Error code: %u\n", GetLastError());
        free(pFileVerInfo);
        return;
    }

    // VerQueryValueW
    LPCWSTR subBlock = L"\\StringFileInfo\\\\ProductVersion";
    VS_FIXEDFILEINFO * pFileInfo;
    UINT pLen = 0;

    if (!VerQueryValueW(pFileVerInfo, subBlock, (LPVOID*)& pFileInfo, &pLen))
    {
        fwprintf(stderr, L"Error code: %u\n", GetLastError());
        return;
    }


    return 0;
}

However, the VerQueryValueW function fails with code 1813 and I have no idea why. I also have no idea how I can show the full version after calling the function.

Can you help me?

Upvotes: 2

Views: 1582

Answers (1)

M.M
M.M

Reputation: 141554

L"\\StringFileInfo\\\\ProductVersion" is not correct. There must be a Language ID in the middle. On my Windows 10 installation, a working string is: L"\\StringFileInfo\\040904B0\\ProductVersion". But maybe this would differ on other systems.

As suggested by Jonathan Potter in comments, you could find the ID by querying \\VarFileInfo\\Translation.

Simpler options to achieve the goal include:

Upvotes: 3

Related Questions