CODEWITHSUNDEEP
windows-10inno-setup
Mike K.
Mike K.

Reputation: 145

Inno setup cannot create desktop icon in windows 10

I have a setup file for Inno setup of latest version. It compiles and works great from Windows XP to Windows 8, but in Windows 10 it fails on the moment when it creates desktop icon with next error:

IPersistFile::Save failed; code 0x80070002

This is how I create icon in setup file:

[Icons]
Name: "{userdesktop}\Forex Tester 4"; Filename: "{app}\ForexTester4.exe"; Tasks: desktopicon

Part of the installation log file:

2019-02-01 12:50:46.376   -- Icon entry --
2019-02-01 12:50:46.376   Dest filename: C:\Users\Mike\Desktop\Forex Tester 4.lnk
2019-02-01 12:50:46.376   Creating the icon.
2019-02-01 12:50:46.376   Exception message:
2019-02-01 12:50:46.376   Message box (OK):
                          IPersistFile::Save failed; code 0x80070002.
                          The system cannot find the file specified.
2019-02-01 12:50:59.066   User chose OK.

This folder exists and I can create files there manually. But inno setup fails to do this... All other icons except desktop one were created without problems.

Any ideas?

Upvotes: 5

Views: 2569

Answers (2)

developer
developer

Reputation: 101

I had the same error on Windows 7 and Windows 10 because I was trying to create shortcut to file that didn't exist yet.

[Icons]
; Create icons for the app
Name: "{group}\{#AppName}"; \
    Filename: "{app}\{#AppName}.lnk"; \
    BeforeInstall: CreateAppRunLink();
Name: "{commondesktop}\{#AppName}"; \
    Filename: "{app}\{#AppName}.lnk"; \
    Tasks: desktopicon;

So I had to make sure that file "{app}{#AppName}.lnk" exists prior to creating the Icon: This goes to [Code] section:

procedure CreateAppRunLink();
var
    Filename: string;
    Description: string;
    ShortcutTo: string;
    Parameters: string;
    WorkingDir: string;
    IconFilename: string;
begin
    Filename := ExpandConstant('{app}\MyApp.lnk');
    Description := 'Description';
    ShortcutTo := 'Full path to file that will be run (MyApp.exe)';
    Parameters := 'parameters if any';
    WorkingDir := ExpandConstant('{app}');
    IconFilename := ExpandConstant('{app}') + '\icon.ico';

    CreateShellLink(Filename, Description, ShortcutTo, Parameters, WorkingDir, 
        IconFilename, 0, SW_HIDE);
end;

CreateAppRunLink will will be called after extracting any files from [Files] section which will make sure that our file is in place.

Upvotes: 0

Splintex
Splintex

Reputation: 1

I had the same issue with an installer without admin privileges :

PrivilegesRequired=lowest

The issue was solved simply by changing common paths to user paths :

[Icons]
Name: "{commonprograms}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"
Name: "{commondesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon

change to :

[Icons]
Name: "{userprograms}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"
Name: "{userdesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon

Upvotes: 0

Related Questions