CODEWITHSUNDEEP
c#unity-game-engine3d2.5d
TheBattleCat
TheBattleCat

Reputation: 119

How to fix "the object of type 'GameObject' has been destroyed, but you are still trying to access it" error in Unity?

I'm creating a 2.5D fighting game in Unity with C#. Currently, I'm trying to make a bumper appear around the player and disappear after a set amount of time. I've managed to make the bumper appear and disappear once, but after that, when I try to make the bumper appear again, Unity has an error for me: "The object of type 'GameObject' has been destroyed but you are still trying to access it."

I've tried using the "instantiate" and "destroy" commands, following a tutorial by "Brackeys" on 2D shooting. After also following some questions on forums about the same issue, I've altered my code again, but the problem persists.

The firePoint is an empty object, from where the BumperPrefab is instantiated.

using UnityEngine;

public class weapon: MonoBehaviour
{
    public Transform firePoint;
    public GameObject BumperPrefab;
    public float lifetime = 0.2f;

void Update()
{
    if (Input.GetButtonDown("Fire1"))
    {
        attack();
    }

}
void attack()
{
    BumperPrefab = (GameObject) Instantiate(BumperPrefab, firePoint.position, firePoint.rotation);
    Destroy(BumperPrefab, lifetime);
}

}

I expect the GameObject "BumperPrefab" to appear, stick around for 0.2 seconds and disappear. I should be able to repeat that as many times as I want, but what actually happens is that I can do this only once and then the error "The object of type 'GameObject' has been destroyed but you are still trying to access it" shows up and I can't make the BumperPrefab appear again.

Any help is much appreciated!

Upvotes: 1

Views: 28701

Answers (4)

vlad
vlad

Reputation: 204

I had similar issue. The root cause is tat first initial object (in this case BumperPrefab) is destroyed and Instantiate tries to clone null and fails. One easy way to solve it would be to set first object (to be cloned by all others) as inactive by calling SetActive(false) in the Start() and then only need to make sure all clones are active. In this case by bumper.SetActive(true)

Upvotes: 0

Jaydeep chatrola
Jaydeep chatrola

Reputation: 2711

problem is you are destroying BumperPrefab

when you Instantiate a new GameObject you should add it to the local variable like this

var newbumper = (GameObject) Instantiate(BumperPrefab, firePoint.position,firePoint.rotation);

and you must destroy your local variable which contains newly created gameObject

Destroy(newbumper , lifetime);

Upvotes: 1

Adam Frańczak
Adam Frańczak

Reputation: 11

The problem is that in your code you don't care about is your GameObject exist. So for example if (for some reason) the object BumperPrefab will not be created, Destory() will try to act on null. You can try add to BumperPrefab script bumper.cs with:

float lifetime = 0.2f;

private void OnEnable()
{
Desroy(this, lifetime)
}

Upvotes: 0

Steven Coull
Steven Coull

Reputation: 478

using UnityEngine;

public class weapon: MonoBehaviour
{
    public Transform firePoint;
    public GameObject BumperPrefab;
    public float lifetime = 0.2f;

void Update()
{
    if (Input.GetButtonDown("Fire1"))
    {
        attack();
    }

}
void attack()
{
    var bumper = (GameObject) Instantiate(BumperPrefab, firePoint.position, firePoint.rotation);
    Destroy(bumper, lifetime);
}

Right now you're overwriting your public field containing the prefab object with your instantiated object, then destroying it. Set the instantiated object as a variable and you should be fine.

Upvotes: 4

Related Questions