CODEWITHSUNDEEP
linuxbashshellscripting
Mujan
Mujan

Reputation: 414

How to use line that read from file in grep command

I'm sorry for my poor English, first. I want to read a file (tel.txt) that contains many tel numbers (a number per line) and use that line to grep command to search about the specific number in the source file (another file)!

I wrote this code :

dir="/home/mujan/Desktop/data/ADSL_CDR_Text_Parts_A"
file="$dir/tel.txt"
datafile="$dir/ADSL_CDR_Like_Tct4_From_960501_to_97501_Part0.txt"

while IFS= read -r line
do
    current="$line"
    echo `grep -F $current "$datafile" >> output.txt`
done < $file

the tel file sample : 

44001547
44001478
55421487

but that code returns nothing! when I declare 'current' variable with literals it works correctly! what happened?!

Upvotes: 0

Views: 2761

Answers (3)

Akhil
Akhil

Reputation: 1050

You should use file descriptors when reading with while loop.instead use for loop to avoid false re-directions

dir="/home/mujan/Desktop/data/ADSL_CDR_Text_Parts_A"
file="$dir/tel.txt"
datafile="$dir/ADSL_CDR_Like_Tct4_From_960501_to_97501_Part0.txt"

for line in `cat $file`
do
    current="$line"
    echo `grep -F $current "$datafile" >> output.txt`
done

Upvotes: 0

tripleee
tripleee

Reputation: 189948

Your grep command is redirected to write its output to a file, so you don't see it on the terminal.

Anyway, you should probably be using the much simpler and faster

grep -Ff "$file" "$datafile"

Add | tee -a output.txt if you want to save the output to a file and see it at the same time.

echo `command` is a buggy and inefficient way to write command. (echo "`command`" would merely be inefficient.) There is no reason to capture standard output into a string just so that you can echo that string to standard output.

Upvotes: 6

Bogdan Stoica
Bogdan Stoica

Reputation: 4529

Why don't you search for the line var directly? I've done some tests, this script works on my linux (CentOS 7.x) with bash shell:

#!/bin/bash
file="/home/mujan/Desktop/data/ADSL_CDR_Text_Parts_A/tel.txt"

while IFS= read -r line
do
    echo `grep "$line" /home/mujan/Desktop/data/ADSL_CDR_Text_Parts_A/ADSL_CDR_Like_Tct4_From_960501_to_97501_Part0.tx >> output.txt`
done < $file

Give it a try... It shows nothing on the screen since you're redirecting the output to the file output.txt so the matching results are saved there.

Upvotes: 0

Related Questions