CODEWITHSUNDEEP
javascripthtml
dogonaroof
dogonaroof

Reputation: 69

Attempting window.location or window.location.href redirect which is causing a loop

I'm attempting to use javascript to determine if the user is using a certain language and if they're not using english then for the page to load a different page BUT with the params of which I've grabbed from the url.

I have been able to load the page with the params but I keep falling into a loop reloading the page, even after skimming through the countless other examples, such as: this or this. 

function locateUserLanguage() {

    var languageValue = (navigator.languages ? navigator.languages[0] : (navigator.language || navigator.userLanguage)).split('-');

        var url = window.location.href.split('?');
        var baseUrl = url[0];
        var urlParams = url[1];


    if (languageValue[0] === 'en') {

        console.log('no redirect needed, stay here.');

    } else {


        // I tried to set location into a variable but also wasn't working.
        // var newURL = window.location.href.replace(window.location.href, 'https://www.mysite.dog/?' + urlParams);


        window.location.href = 'https://www.mysite.dog/?' + urlParams
    }

} locateUserLanguage();

I've attempted to place a return true; as well as return false; but neither stop the loop.

I've tried window.location.replace(); and setting the window.location.href straight to what I need, but it's continuing to loop.

Upvotes: 1

Views: 1765

Answers (1)

Sunil Chaudhary
Sunil Chaudhary

Reputation: 4743

There is a possibility that the script in which this function is written is executed in both of your pages (english and non-english) on load. So, as soon as the page is loaded, locateUserLanguage function is executed in both english and non-english website causing the infinite loop.

You need to put a check before you call locateUserLanguage function.

Suppose english website has url = "www.myside.com" and non-english website has url "www.myside.aus". So the condition needs to be 

if (window.location.host === "www.myside.com") { locateUserLanguage() }

This will make sure that locateUserLanguage is called only in english website.

Or other apporach can be to load this script only in english website which will avoid the usage of conditional statement.

Hope it helps. Revert for any doubts.

Upvotes: 3

Related Questions