CODEWITHSUNDEEP
ruby-on-railsrubyruby-on-rails-3before-filter
choise
choise

Reputation: 25244

before_filter with parameters

I have a method that does something like this:

before_filter :authenticate_rights, :only => [:show]

def authenticate_rights
  project = Project.find(params[:id])
  redirect_to signin_path unless project.hidden
end

I also want to use this method in some other Controllers, so i copied the method to a helper that is included in the application_controller.

the problem is, that in some controllers, the id for the project isn't the :id symbol but f.e. :project_id (and also a :id is present (for another model)

How would you solve this problem? is there an option to add a parameter to the before_filter action (to pass the right param)?

Upvotes: 86

Views: 45383

Answers (5)

Subtletree
Subtletree

Reputation: 3329

I find the block method using curly braces instead of do...end to be the clearest option

before_action(only: [:show]) { authenticate_rights(id) }

before_action is just the newer preferred syntax for before_filter

Upvotes: 6

Alex
Alex

Reputation: 65944

I'd do it like this:

before_filter { |c| c.authenticate_rights correct_id_here }

def authenticate_rights(project_id)
  project = Project.find(project_id)
  redirect_to signin_path unless project.hidden
end

Where correct_id_here is the relevant id to access a Project.

Upvotes: 85

Vadym Tyemirov
Vadym Tyemirov

Reputation: 8833

With some syntactic sugar:

before_filter -> { find_campaign params[:id] }, only: [:show, :edit, :update, :destroy]

Or if you decide to get even more fancy:

before_filter ->(param=params[:id]) { find_campaign param }, only: %i|show edit update destroy|

And since Rails 4 before_action, a synonym to before_filter, was introduced, so it can be written as:

before_action ->(param=params[:id]) { find_campaign param }, only: %i|show edit update destroy|

NB

-> stands for lambda, called lambda literal, introduce in Ruby 1.9

%i will create an array of symbols

Upvotes: 69

Augustin Riedinger
Augustin Riedinger

Reputation: 22148

To continue @alex' answer, if you want to :except or :only some methods, here is the syntax:

before_filter :only => [:edit, :update, :destroy] do |c| c.authenticate_rights params[:id] end

Found here.

Upvotes: 14

Matheus Moreira
Matheus Moreira

Reputation: 17020

This should work:

project = Project.find(params[:project_id] || params[:id])

This should return params[:project_id] if it is present in the params hash, or return params[:id] if it isn't.

Upvotes: -1

Related Questions