Timer script in C#

Question

My timer is still running in update, but it won't stop after a collision. I want to start the timer when thew game starts, and stop when my player collides with an enemy.

Here are my Timer.cs and player (Ship,cs) scripts:

Timer.cs:

[SerializeField]
public Text scoreText;
float startTime;
public const string scorePrefix = "Timer: ";

//Timer initializer
public float elapsedSeconds = 0;

//Stop Timer initializer
bool gameTimerIsRunning = true;

// Start is called before the first frame update
void Start() {
    gameTimerIsRunning = true;
    startTime = 0;
    scoreText.text = scorePrefix + startTime.ToString();
}

// Update is called once per frame
void Update() {
    if (gameTimerIsRunning == true) {
        elapsedSeconds += Time.deltaTime;
        int timer = (int) elapsedSeconds;
        scoreText.text = scorePrefix + timer.ToString();
        Debug.Log("YOO....");
    }
}

public void StopGameTimer() {
    gameTimerIsRunning = false;
    GetComponent < Text > ().text = "Sorry !!";

    Debug.Log("StopGameTimer Is called Succesfully.");
}

Ship.cs:

HUD hud;

[SerializeField]
public GameObject prefabBullet;

Bullet script;

// thrust and rotation support
Rigidbody2D rb2D;
Vector2 thrustDirection = new Vector2(1, 0);
const float ThrustForce = 10;
const float RotateDegreesPerSecond = 180;

/// <summary>
/// Use this for initialization
/// </summary>
void Start() {
    hud = GetComponent < HUD > ();
    //  bullet = prefabBullet.GetComponent<Bullet>();
    // saved for efficiency
    rb2D = GetComponent < Rigidbody2D > ();
}

/// <summary>
/// Update is called once per frame
/// </summary>
void Update() {
    // check for rotation input
    float rotationInput = Input.GetAxis("Rotate");
    if (rotationInput != 0) {

        // calculate rotation amount and apply rotation
        float rotationAmount = RotateDegreesPerSecond * Time.deltaTime;
        if (rotationInput < 0) {
            rotationAmount *= -1;
        }
        transform.Rotate(Vector3.forward, rotationAmount);

        // change thrust direction to match ship rotation
        float zRotation = transform.eulerAngles.z * Mathf.Deg2Rad;
        thrustDirection.x = Mathf.Cos(zRotation);
        thrustDirection.y = Mathf.Sin(zRotation);
    }

    //Firing the Bullet
    if (Input.GetKeyDown(KeyCode.LeftControl)) {
        GameObject bullet = Instantiate(prefabBullet, transform.position, Quaternion.identity);
        bullet.GetComponent < Bullet > ().ApplyForce(thrustDirection);
    }
}

/// <summary>
/// FixedUpdate is called 50 times per second
/// </summary>
void FixedUpdate() {
    // thrust as appropriate
    if (Input.GetAxis("Thrust") != 0) {
        rb2D.AddForce(ThrustForce * thrustDirection, ForceMode2D.Force);
    }
}

/// <summary>
/// Destroys the ship on collision with an asteroid
/// </summary>
/// <param name="coll">collision info</param>
void OnCollisionEnter2D(Collision2D coll) {
    hud = gameObject.AddComponent < HUD > ();

    if (coll.gameObject.CompareTag("Asteroid")) {
        hud.StopGameTimer();
        Destroy(gameObject);
    }
}

I attached my timer script to Hud Canvas and ship script to ship game object.

Answer 1

So The Final Answer is: HUD.cs:

[SerializeField]
public Text scoreText;
//float startTime;
public const string scorePrefix = "Timer: ";

//Timer initializer
float  elapsedSeconds=0;

//Stop Timer initializer
bool gameTimerIsRunning;

// Start is called before the first frame update
void Start()
{


    gameTimerIsRunning = true;

    scoreText.text = scorePrefix + "0";
}

// Update is called once per frame
void Update()
{
    if (gameTimerIsRunning)
    {
        elapsedSeconds += Time.deltaTime;
        int timer = (int)elapsedSeconds;
        scoreText.text = scorePrefix + timer.ToString();
        Debug.Log("YOO....");
    }
    else

    {  }

}

public void StopGameTimer()
{
      gameTimerIsRunning = false;
        elapsedSeconds = 0;
    Debug.Log("Timer Stops.");
 }

---

Ship.cs

 [SerializeField]
public HUD hud;

[SerializeField]
public GameObject prefabBullet;

Bullet script;

// thrust and rotation support
Rigidbody2D rb2D;
Vector2 thrustDirection = new Vector2(1, 0);
const float ThrustForce = 10;
const float RotateDegreesPerSecond = 180;

/// <summary>
/// Use this for initialization
/// </summary>
void Start()
{
      hud = GetComponent<HUD>();
  //  bullet = prefabBullet.GetComponent<Bullet>();
    // saved for efficiency
    rb2D = GetComponent<Rigidbody2D>();
}

/// <summary>
/// Update is called once per frame
/// </summary>
void Update()
{
    // check for rotation input
    float rotationInput = Input.GetAxis("Rotate");
    if (rotationInput != 0)
    {

        // calculate rotation amount and apply rotation
        float rotationAmount = RotateDegreesPerSecond * Time.deltaTime;
        if (rotationInput < 0)
        {
            rotationAmount *= -1;
        }
        transform.Rotate(Vector3.forward, rotationAmount);

        // change thrust direction to match ship rotation
        float zRotation = transform.eulerAngles.z * Mathf.Deg2Rad;
        thrustDirection.x = Mathf.Cos(zRotation);
        thrustDirection.y = Mathf.Sin(zRotation);
    }

    //Firing the Bullet

    if (Input.GetKeyDown(KeyCode.LeftControl))

    {

       GameObject bullet =  Instantiate(prefabBullet, transform.position, Quaternion.identity) ;
        bullet.GetComponent<Bullet>().ApplyForce(thrustDirection);

        AudioManager.Play(AudioClipName.PlayerShot);
    }




}

/// <summary>
/// FixedUpdate is called 50 times per second
/// </summary>
void FixedUpdate()
{
    // thrust as appropriate
    if (Input.GetAxis("Thrust") != 0)
    {
        rb2D.AddForce(ThrustForce * thrustDirection,ForceMode2D.Force);
    }
}

/// <summary>
/// Destroys the ship on collision with an asteroid
/// </summary>
/// <param name="coll">collision info</param>
void OnCollisionEnter2D(Collision2D coll)
{
    hud = GameObject.Find("HUD").GetComponent<HUD>();

    AudioManager.Play(AudioClipName.PlayerDeath);

    if (coll.gameObject.CompareTag("Asteroid"))
    {
        hud.StopGameTimer();
        gameObject.SetActive(false);
       // Destroy(gameObject);

    }
}

---

P.S: This Is the Final_Solution For this Problem.

Answer 2

You should get a reference to the HUD canvas gameobject first:

Change in Ship.cs:

void OnCollisionEnter2D(Collision2D coll) {
    hud = GameObject.Find("HudCanvas").GetComponent < HUD > ();

Assuming that the name of the hud canvas gameobject is "HudCanvas"

Answer 3

hud = gameObject.AddComponent < HUD > ();

Why wrote this line?

Please remove it, because you've already got hud in the Start method:

void Start() {
    hud = GetComponent < HUD > ();
}

Answer 4

public float saveTime = 0;
void Update()
{
    if (gameTimerIsRunning == true)
    {
        if(saveTime == 0) //don't have savetime
        {
            elapsedSeconds += Time.deltaTime;
            int timer = (int)elapsedSeconds;
            scoreText.text = scorePrefix + timer.ToString();
            Debug.Log("YOO....");
        }
        else //have savetime like pause system
        {
            elapsedSeconds = saveTime;
            saveTime = 0;
            int timer = (int)elapsedSeconds;
            scoreText.text = scorePrefix + timer.ToString();
        }
    }
    else if(gameTimerIsRunning == false) //don't Timer running
    {
        saveTime = elapsedSeconds;    //current time save
        int timer = (int)elapsedSeconds;
        scoreText.text = scorePrefix + timer.ToString();
    }
}