Cumulo Nimbus
Cumulo Nimbus

Reputation: 9695

Determine which dependency array variable caused useEffect hook to fire

Is there an easy way to determine which variable in a useEffect's dependency array triggers a function re-fire?

Simply logging out each variable can be misleading, if a is a function and b is an object they may appear the same when logged but actually be different and causing useEffect fires.

For example:

React.useEffect(() => {
  // which variable triggered this re-fire?
  console.log('---useEffect---')
}, [a, b, c, d])

My current method has been removing dependency variables one by one until I notice the behavior that causes excessive useEffect calls, but there must be a better way to narrow this down.

Upvotes: 296

Views: 100783

Answers (11)

Noumenon
Noumenon

Reputation: 6412

The React docs suggest these steps:

  • Log your dependency array with console.log:
  const visibleTodos = useMemo(() => filterTodos(todos, tab), [todos, tab]);
  console.log([todos, tab]);
  • Right-click on the arrays from different re-renders in the console and select “Store as a global variable” for both of them. It may be important not to compare two sequential ones if you are in strict mode, I'm not sure.
  • Compare each of the dependencies:
  Object.is(temp1[0], temp2[0]); // Is the first dependency the same between the arrays?

Upvotes: 3

stanley
stanley

Reputation: 11

function handle(trigger){
    console.log("trigged by " + trigger)
}

useEffect(() => {
    handle("a")
}, [a])

useEffect(() => {
    handle("b")
}, [b])

Upvotes: 0

Affan Ansari
Affan Ansari

Reputation: 13

I was having the same problem, my useEffect was running more than once. What I did to find out what was causing this was I put a log statement in the beginning, to find out how many times it was running, and then I started removing the dependancies one by one and watching how many times that console.log was running. So, when the number of log statements reduce, it will be that dependancy which you removed which was causing the execution of useEffect more than once.

useEffect(() => {
console.log('I ran'); // Log statement to keep track of how many times useEffect is running
// your stuff
}, [d1, d2, d3, d4]); //Dependancies

So, remove these dependancies one by one and keep track of the console.log. If the number reduces, that dependancy was causing the issue.

Upvotes: 0

Ron Newcomb
Ron Newcomb

Reputation: 3302

I think I prefer the one mentioned in the OP comment, just copy-paste a useEffect for each single dependency. Super easy to understand and no real chance of new, complicated code/library going pear-shaped.

      . // etc in big hook
      .
      return complicated(thing);
    },
    [api, error, needsSeqs, throttle]
  );

  useEffect(() => console.log('api'), [api]);
  useEffect(() => console.log('error'), [error]);
  useEffect(() => console.log('needsSeqs'), [needsSeqs]);
  useEffect(() => console.log('throttle'), [throttle]);

Upvotes: 10

Jonathan Tuzman
Jonathan Tuzman

Reputation: 13262

I expanded on @Bradley's answer so this can be used with useMemo and useCallback as well. I'm pretty sure it works, though I haven't thoroughly tested it. Note that they all return their hooks, since useMemo and useCallback need returns. I haven't seen any ill effects with returning useEffect this way. Feel free to comment if you see problems or fixes.

import React, { useEffect, useRef } from 'react'

const usePrevious = (value, initialValue) => {
  const ref = useRef(initialValue)
  useEffect(() => {
    ref.current = value
  })
  return ref.current
}

const hookTypes = ['Effect', 'Memo', 'Callback'] as const
export const debuggers = hookTypes.reduce(
  (obj, hookType) => ({
    ...obj,
    [`use${hookType}Debugger`]: (
      effectHook,
      dependencies,
      dependencyNames = [],
      hookName = ''
    ) => {
      const previousDeps = usePrevious(dependencies, [])

      const changedDeps = dependencies.reduce((accum, dependency, index) => {
        if (dependency !== previousDeps[index]) {
          const keyName = dependencyNames[index] || index
          return {
            ...accum,
            [keyName]: {
              before: previousDeps[index],
              after: dependency,
            },
          }
        }

        return accum
      }, {} )

      if (Object.keys(changedDeps).length) {
        console.log(`[use-${hookType.toLowerCase()}-debugger] `, hookName, changedDeps)
      }

      // @ts-ignore
      return React[`use${hookType}`](effectHook, dependencies)
    },
  }),
  {} as Record<`use${typeof hookTypes[number]}Debugger`, (
    effectHook: Function,
    dependencies: Array<any>,
    dependencyNames?: string[],
    hookName?: string
  ) => any>
)

Upvotes: 0

Devin Rhode
Devin Rhode

Reputation: 25287

@simbathesailor/use-what-changed works like a charm!

  1. Install with npm/yarn and --dev or --no-save

  2. Add import:

    import { useWhatChanged } from '@simbathesailor/use-what-changed';
    
  3. Call it:

    // (guarantee useEffect deps are in sync with useWhatChanged)
    let deps = [a, b, c, d]
    
    useWhatChanged(deps, 'a, b, c, d');
    useEffect(() => {
      // your effect
    }, deps);
    

Creates this nice chart in the console:

image loaded from github

There are two common culprits:

  1. Some Object being pass in like this:
// Being used like:
export function App() {
  return <MyComponent fetchOptions={{
    urlThing: '/foo',
    headerThing: 'FOO-BAR'
  })
}
export const MyComponent = ({fetchOptions}) => {
  const [someData, setSomeData] = useState()
  useEffect(() => {
    window.fetch(fetchOptions).then((data) => {
      setSomeData(data)
    })

  }, [fetchOptions])

  return <div>hello {someData.firstName}</div>
}

The fix in the object case, if you can, break-out a static object outside the component render:

const fetchSomeDataOptions = {
  urlThing: '/foo',
  headerThing: 'FOO-BAR'
}
export function App() {
  return <MyComponent fetchOptions={fetchSomeDataOptions} />
}

You can also wrap in useMemo:

export function App() {
  return <MyComponent fetchOptions={
    useMemo(
      () => {
        return {
          urlThing: '/foo',
          headerThing: 'FOO-BAR',
          variableThing: hash(someTimestamp)
        }
      },
      [hash, someTimestamp]
    )
  } />
}

The same concept applies to functions to an extent, except you can end up with stale closures.

Upvotes: 82

Noam L
Noam L

Reputation: 119

This question was answered with several good and working answers, but I just didn't like the DX of any of them.

so I wrote a library which logs the dependencies that changed in the easiest way to use + added a function to log a deep comparison between 2 objects, so you can know what exactly changed inside your object.

I called it: react-what-changed

The readme has all of the examples you need.

The usage is very straight forward:

npm install react-what-changed --save-dev
import { reactWhatChanged as RWC } from 'react-what-changed';

function MyComponent(props) {
  useEffect(() => {
    someLogic();
  }, RWC([somePrimitive, someArray, someObject]));
}

In this package you will also find 2 useful functions for printing deep comparison (diffs only) between objects. for example:

import { reactWhatDiff as RWD } from 'react-what-changed';

function MyComponent(props) {
  useEffect(() => {
    someLogic();
  }, [somePrimitive, someArray, someObject]);

  RWD(someArray);
}

Upvotes: 0

Bradley
Bradley

Reputation: 2998

I ended up taking a little bit from various answers to make my own hook for this. I wanted the ability to just drop something in place of useEffect for quickly debugging what dependency was triggering useEffect.

const usePrevious = (value, initialValue) => {
  const ref = useRef(initialValue);
  useEffect(() => {
    ref.current = value;
  });
  return ref.current;
};
const useEffectDebugger = (effectHook, dependencies, dependencyNames = []) => {
  const previousDeps = usePrevious(dependencies, []);

  const changedDeps = dependencies.reduce((accum, dependency, index) => {
    if (dependency !== previousDeps[index]) {
      const keyName = dependencyNames[index] || index;
      return {
        ...accum,
        [keyName]: {
          before: previousDeps[index],
          after: dependency
        }
      };
    }

    return accum;
  }, {});

  if (Object.keys(changedDeps).length) {
    console.log('[use-effect-debugger] ', changedDeps);
  }

  useEffect(effectHook, dependencies);
};

Below are two examples. For each example, I assume that dep2 changes from 'foo' to 'bar'. Example 1 shows the output without passing dependencyNames and Example 2 shows an example with dependencyNames.

Example 1

Before:

useEffect(() => {
  // useEffect code here... 
}, [dep1, dep2])

After:

useEffectDebugger(() => {
  // useEffect code here... 
}, [dep1, dep2])

Console output:

{
  1: {
    before: 'foo',
    after: 'bar'
  }
}

The object key '1' represents the index of the dependency that changed. Here, dep2 changed as it is the 2nd item in the dependency, or index 1.

Example 2

Before:

useEffect(() => {
  // useEffect code here... 
}, [dep1, dep2])

After:

useEffectDebugger(() => {
  // useEffect code here... 
}, [dep1, dep2], ['dep1', 'dep2'])

Console output:

{
  dep2: {
    before: 'foo',
    after: 'bar'
  }
}

Upvotes: 278

arcanereinz
arcanereinz

Reputation: 265

There’s another stack overflow thread stating you can use useRef to see a previous value.

https://reactjs.org/docs/hooks-faq.html#how-to-get-the-previous-props-or-state

Upvotes: 5

Ryan Cogswell
Ryan Cogswell

Reputation: 81036

UPDATE

After a little real-world use, I so far like the following solution which borrows some aspects of Retsam's solution:

const compareInputs = (inputKeys, oldInputs, newInputs) => {
  inputKeys.forEach(key => {
    const oldInput = oldInputs[key];
    const newInput = newInputs[key];
    if (oldInput !== newInput) {
      console.log("change detected", key, "old:", oldInput, "new:", newInput);
    }
  });
};
const useDependenciesDebugger = inputs => {
  const oldInputsRef = useRef(inputs);
  const inputValuesArray = Object.values(inputs);
  const inputKeysArray = Object.keys(inputs);
  useMemo(() => {
    const oldInputs = oldInputsRef.current;

    compareInputs(inputKeysArray, oldInputs, inputs);

    oldInputsRef.current = inputs;
  }, inputValuesArray); // eslint-disable-line react-hooks/exhaustive-deps
};

This can then be used by copying a dependency array literal and just changing it to be an object literal:

useDependenciesDebugger({ state1, state2 });

This allows the logging to know the names of the variables without any separate parameter for that purpose.

Edit useDependenciesDebugger

Upvotes: 19

Retsam
Retsam

Reputation: 33409

As far as I know, there's no really easy way to do this out of the box, but you could drop in a custom hook that keeps track of its dependencies and logs which one changed:

// Same arguments as useEffect, but with an optional string for logging purposes
const useEffectDebugger = (func, inputs, prefix = "useEffect") => {
  // Using a ref to hold the inputs from the previous run (or same run for initial run
  const oldInputsRef = useRef(inputs);
  useEffect(() => {
    // Get the old inputs
    const oldInputs = oldInputsRef.current;

    // Compare the old inputs to the current inputs
    compareInputs(oldInputs, inputs, prefix)

    // Save the current inputs
    oldInputsRef.current = inputs;

    // Execute wrapped effect
    func()
  }, inputs);
};

The compareInputs bit could look something like this:

const compareInputs = (oldInputs, newInputs, prefix) => {
  // Edge-case: different array lengths
  if(oldInputs.length !== newInputs.length) {
    // Not helpful to compare item by item, so just output the whole array
    console.log(`${prefix} - Inputs have a different length`, oldInputs, newInputs)
    console.log("Old inputs:", oldInputs)
    console.log("New inputs:", newInputs)
    return;
  }

  // Compare individual items
  oldInputs.forEach((oldInput, index) => {
    const newInput = newInputs[index];
    if(oldInput !== newInput) {
      console.log(`${prefix} - The input changed in position ${index}`);
      console.log("Old value:", oldInput)
      console.log("New value:", newInput)
    }
  })
}

You could use this like this:

useEffectDebugger(() => {
  // which variable triggered this re-fire?
  console.log('---useEffect---')
}, [a, b, c, d], 'Effect Name')

And you would get output like:

Effect Name - The input changed in position 2
Old value: "Previous value"
New value: "New value"

Upvotes: 10

Related Questions