CODEWITHSUNDEEP
javascriptunit-testingsinon
fgonzalez
fgonzalez

Reputation: 3877

sinon stub does not recognise a call to a stub

This is the code to test:

    const AWS = require('aws-sdk');
const { APPLICATIONS, NOTIFICATION_FREQUENCIES } = require('./config');

exports.createHandler = ({ notificationService }) => async (event, context) => {

  try{
    Object.values(APPLICATIONS).forEach(async appId => {

      const notifications =  await notificationService
        .getNotificationsByApplication(appId);



      const dailyNotifications =notifications.filter(
        e =>
          e.frequency === NOTIFICATION_FREQUENCIES.DAILY,
      );

      console.log('dailyNo', dailyNotifications);

      const dailyTemplate = notificationService.prepareDailyTemplate(
        dailyNotifications
      );
      console.log('dailyTemplate', dailyTemplate);

      notificationService.notifyToAdmin(dailyTemplate);
    });
  }
  catch(err) {
    console.log(err);
  }

};

And this is my test using sinon:

const sinon = require('sinon');
const { APPLICATIONS, NOTIFICATION_FREQUENCIES } = require('../lib/config');
describe('Daily notifier tests', () => {

  it('should prepare daily template for each of the applications', () => {

    const notificationService = require('../lib/notificationService').createHandler({
      commands: {},
      simpleMailService: {},
    });

    const notifications = [
      {
        type: 'create_order',
        frequency: NOTIFICATION_FREQUENCIES.DAILY,
      },
      {
        type: 'create_order',
        frequency: NOTIFICATION_FREQUENCIES.DAILY,
      },
      {
        type: 'create_order',
        frequency: NOTIFICATION_FREQUENCIES.MONTHLY,
      },
    ];
    const template = 'some html template as string';

    sinon.stub(notificationService, 'getNotificationsByApplication').resolves(notifications);
    sinon.stub(notificationService, 'prepareDailyTemplate').returns(template);
    sinon.stub(notificationService, 'notifyToAdmin');

    const sut = require('../lib/dailyNotifier').createHandler({
      notificationService,
    });

    const event = {};
    const context = {};


    sut(event, context);

    const dailyNotifications = [
      {
        type: 'create_order',
        frequency: NOTIFICATION_FREQUENCIES.DAILY,
      },
      {
        type: 'create_order',
        frequency: NOTIFICATION_FREQUENCIES.DAILY,
      }
    ];

    sinon.assert.calledOnce(notificationService.prepareDailyTemplate);
    sinon.assert.calledWith(notificationService.notifyToAdmin, template);


  });

});

According to sinon the method prepareDailyTemplate is not called at all (0 times), but when I execute the test I can even see the console.log 'dailyTemplate', which means that the method has been executed once. The error message:

AssertError: expected prepareDailyTemplate to be called once but was called 0 times

What I am doing wrong?

Upvotes: 1

Views: 47

Answers (1)

Brian Adams
Brian Adams

Reputation: 45780

sut is an async function created by createHandler so it returns a Promise.

You just need to await the Promise that it returns:

it('should prepare daily template for each of the applications', async () => {  // <= async

  // ...

  await sut(event, context);  // <= await

  // ...

  sinon.assert.calledOnce(notificationService.prepareDailyTemplate);  // Success!
});

Upvotes: 1

Related Questions