CODEWITHSUNDEEP
pythonreturnreturn-valueodoo
Nabil Taleb
Nabil Taleb

Reputation: 137

Why the function does not return the value?

I didn't understand why the function does not return in python, My function counts the number of days (Friday and Saturday) between two dates but it does not return

Here's my code : 

# -*- coding: utf-8 -*-

import datetime
import calendar
calendar.setfirstweekday(calendar.SUNDAY)

from odoo import models, fields, api

class HrMission(models.Model):
    _name = "hr.employee.mission"
    _description = "hr mission"
    _inherit = "hr.employee.mission"

    days_compensation =fields.Float(compute='get_compensation', compstring='Jours de récupération', help="Jours de récupération si la mission contient les jours de repos",
                             required=True, readonly=True,)

    @api.multi
    @api.depends('mission_start_date', 'mission_end_date')
    def get_compensation(self):
        for rec in self:
            if rec.mission_start_date and rec.mission_end_date:
                time1 = datetime.datetime.strptime(rec.mission_start_date, "%Y-%m-%d")
                time2 = datetime.datetime.strptime(rec.mission_end_date, "%Y-%m-%d")
                week = {}
                leave_value = {}
        # Compute Number Of Friday And Saturday
                for i in range((time2 - time1).days):
                    day = calendar.day_name[(time1 + datetime.timedelta(days=i+1)).weekday()]
                    week[day] = week[day] + 1 if day in week else 1                    
                fri = week.get('Friday') if 'Friday' in week else 0  # Result Number 1 Of friday If "Start Date", "End date" --> "02/04/2019", "07/04/2019"
                sat = week.get('Saturday') if 'Saturday' in week else 0 # Same thing that Friday, Numbre 1 for Saturday
                friandsat = fri + sat # Result 2
                return friandsat

Upvotes: 0

Views: 208

Answers (3)

Hilar AK
Hilar AK

Reputation: 1675

  1. Remove the readonly Attribute where compute field is readonly in default unless inverse is given.
  2. Make the field store = True

  3. Update Code

    @api.depends('mission_start_date', 'mission_end_date') def get_compensation(self): for rec in self: if rec.mission_start_date and rec.mission_end_date: time1 = datetime.datetime.strptime(rec.mission_start_date, "%Y-%m-%d") time2 = datetime.datetime.strptime(rec.mission_end_date, "%Y-%m-%d") week = {} leave_value = {} # Compute Number Of Friday And Saturday for i in range((time2 - time1).days): day = calendar.day_name[(time1 + datetime.timedelta(days=i + 1)).weekday()] week[day] = week[day] + 1 if day in week else 1 fri = week.get( 'Friday') if 'Friday' in week else 0 # Result Number 1 Of friday If "Start Date", "End date" --> "02/04/2019", "07/04/2019" sat = week.get('Saturday') if 'Saturday' in week else 0 # Same thing that Friday, Numbre 1 for Saturday rec.days_compensation = fri + sat # Result 2

Upvotes: 0

Amit Nanaware
Amit Nanaware

Reputation: 3356

You have to define friandsat at the starting and and the end of function return in outside of the for loop:

def get_compensation(self):
    friandsat = 0
    for rec in self:
        if rec.mission_start_date and rec.mission_end_date:
            time1 = datetime.datetime.strptime(rec.mission_start_date, "%Y-%m-%d")
            time2 = datetime.datetime.strptime(rec.mission_end_date, "%Y-%m-%d")
            week = {}
            leave_value = {}
    # Compute Number Of Friday And Saturday
            for i in range((time2 - time1).days):
                day = calendar.day_name[(time1 + datetime.timedelta(days=i+1)).weekday()]
                week[day] = week[day] + 1 if day in week else 1
            fri = week.get('Friday') if 'Friday' in week else 0  # Result Number 1 Of friday If "Start Date", "End date" --> "02/04/2019", "07/04/2019"
            sat = week.get('Saturday') if 'Saturday' in week else 0 # Same thing that Friday, Numbre 1 for Saturday
            friandsat = fri + sat # Result 2
    return friandsat

Upvotes: 0

Bhavesh Odedra
Bhavesh Odedra

Reputation: 11141

You need to assign value on that field. For example, rec.days_compensation = float_number

@api.multi
@api.depends('mission_start_date', 'mission_end_date')
def get_compensation(self):
    for rec in self:
        if rec.mission_start_date and rec.mission_end_date:
            time1 = datetime.datetime.strptime(rec.mission_start_date, "%Y-%m-%d")
            time2 = datetime.datetime.strptime(rec.mission_end_date, "%Y-%m-%d")
            week = {}
            leave_value = {}
            # Compute Number Of Friday And Saturday
            for i in range((time2 - time1).days):
                day = calendar.day_name[(time1 + datetime.timedelta(days=i+1)).weekday()]
                week[day] = week[day] + 1 if day in week else 1                    
            fri = week.get('Friday') if 'Friday' in week else 0  # Result Number 1 Of friday If "Start Date", "End date" --> "02/04/2019", "07/04/2019"
            sat = week.get('Saturday') if 'Saturday' in week else 0 # Same thing that Friday, Numbre 1 for Saturday
            friandsat = fri + sat # Result 2
            rec.days_compensation = friandsat

Upvotes: 1

Related Questions