CODEWITHSUNDEEP
c++
Rni224
Rni224

Reputation: 15

C++ Class vector error, expression must have pointer type

Currently learning some c++ and unsure why this is giving me "expression must have pointer type".

Mapp.hpp 

class RouteMap
{
public:
    RouteMap();
    string getCurrent_();
    void StoreCity(string b);
private:
    std::vector<string>* cities();
    string current_; 
};

mapp.cpp 

RouteMap::RouteMap(){}

string RouteMap::getCurrent_()
{
    return current_; 
}

void RouteMap::StoreCity(string b)
{
    cities->push_back(b); //Error 
}

std::vector<string> RouteMap::cities()
{
    return std::vector<string>();
}

I am attempting to have a vector Cities as a private member so that when I run the member function StoreCity(string x), it would push_back the specific string into Cities.

Upvotes: 0

Views: 389

Answers (1)

user10957435
user10957435

Reputation:

I'm going to take a stab and say that the problem is cities() is a function and requires parenthesis:

cities()->push_back(b);

Edit Just found the implementation of cities() (silly me). You have another problem, and that is that your declaration and implementation don't match.

// declaration
std::vector<string>* cities();

// implementation. Notice the lack of a pointer type return
std::vector<string> RouteMap::cities()
{
    return std::vector<string>();
}

It's also weird that you're returning a new vector each time. You probably want a member variable:

class RouteMap
{
//...
private:
std::vector<string> my_cities;
//...
};

and then return the member variable from there:

std::vector<string>* RouteMap::cities()
{
    return &my_cities;
}

Edit2: It has come to my attention that you probably, while you could fix these things like this and get it working, the truth is that you probably don't mean for cities() to be a function at all. You probably mean for it to be a member variable instead:

class RouteMap
{
//...
private:
std::vector<string> cities;
//...
};

This requires no implementation, (aka RouteMap::cities(){}), and you can just use it inside any member function (because it's a private member) like current_.

Upvotes: 2

Related Questions