CODEWITHSUNDEEP
javafile-iorecursion
Martin McNulty
Martin McNulty

Reputation: 2631

Deleting non-empty directories in Java

Supposing I have a File f that represents a directory, then f.delete() will only delete the directory if it is empty. I've found a couple of examples online that use File.listFiles() or File.list() to get all the files in the directory and then recursively traverses the directory structure and delete all the files. However, since it's possible to create infinitely recursive directory structures (in both Windows and Linux (with symbolic links)) presumably it's possible that programs written in this style might never terminate.

So, is there a better way to write such a program so that it doesn't fall into these pitfalls? Do I need to keep track of everywhere I've traversed and make sure I don't go around in circles or is there a nicer way?

Update: In response to some of the answers (thanks guys!) - I'd rather the code didn't follow symbolic links and stayed within the directory it was supposed to delete. Can I rely on the Commons-IO implementation to do that, even in the Windows case?

Upvotes: 36

Views: 37565

Answers (5)

Il-Bhima
Il-Bhima

Reputation: 10880

If you really want your recursive directory deletion to follow through symbolic links, then I don't think there is any platform independent way of doing so without keeping track of all the directories you have traversed.

However, in pretty much every case I can think of you would just want to delete the actual symbolic link pointing to the directory rather than recursively following through the symbolic link.

If this is the behaviour you want then you can use the FileUtils.deleteDirectory method in Apache Commons IO.

Upvotes: 43

Sebastian Ganslandt
Sebastian Ganslandt

Reputation: 965

At least under MacOSX, deleting a symbolic link to a directory does not delete the directory itself, and can therefore be deleted even if the target directory is not empty.

I assume this holds for most POSIX operating systems. And as far as I know, links under windows are also just files, and can be deleted as such from a Java program.

Upvotes: 0

Joshua Fox
Joshua Fox

Reputation: 19655

Try Apache Commons IO for a tested implementation.

However, I don't think it this handles the infinite-recursion problem.

Upvotes: 9

Morendil
Morendil

Reputation: 3968

If you could know which files are symlinks, you could just skip over those.

There is unfortunately no "clean" way of detecting symlinks in Java. Check out this pure Java workaround or this one involving native code.

Upvotes: 0

Bombe
Bombe

Reputation: 83847

File.getCanonicalPath() will tell you the “real” name of the file, including resolved symlinks. When while scanning you come across a directory you alread know (because you stored them in a Map) bail out.

Upvotes: 4

Related Questions