CODEWITHSUNDEEP
javascriptperformancetimeout
zapping
zapping

Reputation: 4116

Memory leak for javascript setInterval

Is there any difference between these 2 statements

setInterval(animateImage, 1000);

or 

setInterval('animateImage()', 1000);

Will the second statement be interpreted by the browser js engine is any different way that could cause memory leak or performance issues. Same is the case with the setTimeout() call. The application makes use of 4 timer calls with 1-2 sec intervals.

Upvotes: 3

Views: 3510

Answers (5)

ipopa
ipopa

Reputation: 1223

I recommend using it like so:

setInterval(function(param1, param2){animateImage(param1, param2)}, 1000);

to pass parameters instead of passing them at the end

Upvotes: 0

Felix Kling
Felix Kling

Reputation: 816404

The biggest difference is that the second statement will cause animateImage() to be evaluated in global scope.

This can lead to problems if

  • animateImage is not in global scope
  • animateImage has to access variables that are not in global scope

E.g. the following will not work:

function foo() {
    var answer = 42;
    function bar() {
        alert(answer);
    }
    setTimeout('bar()', 1000);
}

foo();

Actually there is never a reason to use the second statement, so the question about memory leaks is not relevant anymore ;)

And obviously, passing a direct reference to a function will be 'faster' than evaluating a string.

Upvotes: 6

Cybercartel
Cybercartel

Reputation: 12592

I don't think so. You want to use callbacks to avoid memory leaks.

Upvotes: 0

ThiefMaster
ThiefMaster

Reputation: 318508

Use the first one. It makes debugging nicer since there's no eval'd code involved, it is faster and cleaner. Eval is evil and it's good to avoid it whenever possible.

In case you ever need to pass an argument, use the following code:

setInterval(function() {
    animateImage(...);
}, 1000);

Upvotes: 3

Matthew Crumley
Matthew Crumley

Reputation: 102725

The second statement will probably be slightly slower and use more memory, but it wouldn't be significant either way. You should Use the first one regardless, because it's generally best to avoid using eval.

Upvotes: 2

Related Questions